Closed
Bug 810139
Opened 12 years ago
Closed 12 years ago
Update IdentityUtils.jsm to work with jsloader.reuseGlobal = true
Categories
(Core Graveyard :: Identity, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 809265
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently loading the marketplace on b2g, the navigator.id DOM component tries to load a jsm that fails:
E/GeckoConsole( 4112): [JavaScript Error: "resource://gre/modules/IdentityUtils.jsm - EXPORTED_SYMBOLS is not an array." {file: "jar:file:///system/b2g/omni.ja!/components/nsDOMIdentity.js" line: 19}]
E/GeckoConsole( 4112): [JavaScript Error: "NS_ERROR_FACTORY_NOT_REGISTERED: Factory not registered" {file: "https://login.persona.org/include.js" line: 8}]
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → fabrice
Attachment #679905 -
Flags: review?(philipp)
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Comment 2•12 years ago
|
||
I believe that once the patch for Bug 809265 lands, this will be fixed. The problem is that some identity jsm and js modules appear to have been overlooked in the upgrade to the new global object architecture.
Comment 3•12 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #1)
> Created attachment 679905 [details] [diff] [review]
> patch
Thank you for doing that, Fabrice, but the patch to Bug 809265 includes this.
Comment 4•12 years ago
|
||
(In reply to Jed Parsons [:jparsons] from comment #2)
> I believe that once the patch for Bug 809265 lands, this will be fixed.
Ok, that's great! It looks like that's ready to land. If not, can we land this simple fix first to make the Marketplace work again on the phone. In this case, perhaps you guys can r+ it.
> The problem is that some identity jsm and js modules appear to have been
> overlooked in the upgrade to the new global object architecture.
Yeah, fixing the world is hard when it takes a few days and code changes underneath you. Things were bound to be missed.
Updated•12 years ago
|
Assignee: jparsons → fabrice
Status: NEW → RESOLVED
Closed: 12 years ago
No longer depends on: 809265
Resolution: --- → DUPLICATE
Updated•12 years ago
|
Attachment #679905 -
Flags: review?(philipp)
Comment 6•12 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> (In reply to Jed Parsons [:jparsons] from comment #2)
> > I believe that once the patch for Bug 809265 lands, this will be fixed.
>
> Ok, that's great! It looks like that's ready to land. If not, can we land
> this simple fix first to make the Marketplace work again on the phone. In
> this case, perhaps you guys can r+ it.
Thank you Philipp, and please ignore my completely inaccurate Comment #3. Bug 809265 is r=benadida already.
> > The problem is that some identity jsm and js modules appear to have been
> > overlooked in the upgrade to the new global object architecture.
>
> Yeah, fixing the world is hard when it takes a few days and code changes
> underneath you. Things were bound to be missed.
Actually I'm pretty amazed how few glitches there were for an update of this magnitude. Kudos to you and Kyle and everyone who pulled it off so quickly and cleanly!
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•