Closed
Bug 810494
Opened 12 years ago
Closed 12 years ago
Objects/embeds with a known mime type shouldn't trigger plugin errors
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox17 wontfix, firefox18+ fixed, firefox19+ fixed, firefox20 fixed, firefox-esr1018+ wontfix, firefox-esr17 fixed)
People
(Reporter: johns, Assigned: johns)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
jaas
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-esr17+
johns
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jaas
:
review+
johns
:
checkin+
|
Details | Diff | Splinter Review |
A tag as such:
> <embed type="image/png">
Will trigger a missing plugin error, which is obviously bogus. Bug 548133 will expand this issue to object tags, causing some test failures
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #680257 -
Flags: review?(joshmoz)
Assignee | ||
Updated•12 years ago
|
Attachment #680257 -
Flags: review?(joshmoz)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 680257 [details] [diff] [review]
Don't show plugin errors for types we recognize but are not loading for another reason
Okay the try run failures were due to pushing the wrong patch, this is ready for review after all.
Attachment #680257 -
Flags: review?(joshmoz)
Attachment #680257 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 680257 [details] [diff] [review]
Don't show plugin errors for types we recognize but are not loading for another reason
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e50e8c6c5cf
Try:
https://tbpl.mozilla.org/?tree=Try&rev=7ac49c949717
Attachment #680257 -
Flags: checkin+
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 680257 [details] [diff] [review]
Don't show plugin errors for types we recognize but are not loading for another reason
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Unknown, rather old behavior
User impact if declined:
Tags such as <embed type="text/html">, that are of a valid type but lack a URI, will display a missing-plugin error, which is obviously bogus. (but have done so since at least 15, likely longer)
Testing completed (on m-c, etc.):
On m-c
Risk to taking this patch (and alternatives if risky):
Low, removes uncommon but bogus behavior unique to FF, might change display of sites doing odd things.
String or UUID changes made by this patch:
None
This blocks landing bug 800018 on beta
Attachment #680257 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 680257 [details] [diff] [review]
Don't show plugin errors for types we recognize but are not loading for another reason
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
This is needed if we want to take bug 800018 on 17esr, otherwise is not worth uplifting. See comments there.
Attachment #680257 -
Flags: approval-mozilla-esr17?
Assignee | ||
Updated•12 years ago
|
Attachment #680257 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #680257 -
Flags: approval-mozilla-esr17?
Attachment #680257 -
Flags: approval-mozilla-esr17+
Attachment #680257 -
Flags: approval-mozilla-beta?
Attachment #680257 -
Flags: approval-mozilla-beta+
Attachment #680257 -
Flags: approval-mozilla-aurora?
Attachment #680257 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
status-firefox-esr10:
--- → affected
status-firefox18:
--- → affected
status-firefox19:
--- → affected
tracking-firefox-esr10:
--- → 18+
Updated•12 years ago
|
tracking-firefox18:
--- → +
tracking-firefox19:
--- → +
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f800cff693d6
https://hg.mozilla.org/releases/mozilla-beta/rev/fc9677f8a2f6
https://hg.mozilla.org/releases/mozilla-esr17/rev/b49489fb8164
status-firefox20:
--- → fixed
status-firefox-esr17:
--- → fixed
Assignee | ||
Comment 9•12 years ago
|
||
bug 817981 points out that this was fixed by 745030 and then regressed at some point before being fixed again, going to add a test case here.
Flags: in-testsuite?
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 10•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #688494 -
Flags: feedback?(dkeeler)
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 688494 [details] [diff] [review]
Test
Err, actually, this would work just fine as a content mochitest
Attachment #688494 -
Attachment is obsolete: true
Attachment #688494 -
Flags: feedback?(dkeeler)
Assignee | ||
Comment 12•12 years ago
|
||
Makes sure that loading non-plugin types into these tags always ends up using
alternate content, rather than plugin-specific error modes
Attachment #688500 -
Flags: review?(joshmoz)
Attachment #688500 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 13•12 years ago
|
||
Comment on attachment 688500 [details] [diff] [review]
Test
https://hg.mozilla.org/integration/mozilla-inbound/rev/704d7d2ac810
Attachment #688500 -
Flags: checkin+
Comment 14•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Flags: in-testsuite? → in-testsuite+
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•