I can do a mozmill test to check correct operation of code added in bug 80855, bug 327812, bug 208628, bug 530142, bug 720199, bug 536768. Let's call it test-account-values.js.

++

I try to do bug 80855 in a separate xpcshell test as it does not need the full UI running.

Comment on attachment 716262 [details] [diff] [review] patch Review of attachment 716262 [details] [diff] [review]: ----------------------------------------------------------------- These are really well written tests, and they pass for me with flying colours. Thumbs up, I love it. ::: mail/test/mozmill/account/test-account-values.js @@ +5,5 @@ > +/** > + * This test checks proper operation of the account settings panes > + * when certain special or invalid values are entered into the fields. > + * > + * New checks can be added to it as needed. I think this is implied - can probably remove this line.

Oh, finally :)

The remaining test. Neil, can you think up any invalid IPs/hostnames to add?

Comment on attachment 734291 [details] [diff] [review] test for 80855 Seems reasonable, but do you want to add things like 127.1 and 10.100.1000 as valid extended IP addresses?

These will not currently pass. I see these are valid as even 'ping' in linux accepts them fine. I remember we discussed them in bug 80855. We have bug 809609 to add support of these. We can update the test in that bug.

Comment on attachment 734291 [details] [diff] [review] test for 80855 Those are some good looking tests! +1!