Closed
Bug 810943
Opened 12 years ago
Closed 12 years ago
On Android, disable WebGL conformance tests that cause frequent timeouts
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
Attachments
(1 file)
add ability to skip webgl pages on Android by listing them in a text file, skipped_tests_android.txt
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
We have many intermittent oranges in The WebGL mochitest on Android:
bug 789000 in conformance/textures/gl-teximage.html
bug 777574 in conformance/more/conformance/quickCheckAPI-B2.html
bug 772405 in conformance/textures/tex-image-and-sub-image-2d-with-image.html
bug 803597 in conformance/textures/gl-teximage.html
bug 714491 in conformance/programs/gl-getshadersource.html
bug 737371 in conformance/reading/read-pixels-test.html
These are enough different pages that disabling one of them has little effect, but few enough pages that we can have hipe that by disabling just _all of_ these ones, we could fix the issues and still have good coverage. So let's disable them all at once.
We need to have an easy way to disable a test page on Android only. Should be doable by just editing a text file, say skipped_tests_android.txt.
Comment 1•12 years ago
|
||
Thank you for looking at this :-)
On Android, we already have the capability to disable single test (or even entire directories), using:
https://hg.mozilla.org/mozilla-central/file/b2bdbfe06b10/testing/mochitest/android.json
OS: Linux → Android
Hardware: x86_64 → ARM
Assignee | ||
Comment 2•12 years ago
|
||
This only allows disabling a _whole_ mochitest. The entirety of 300+ WebGL conformance test pages are all run as a single mochitest.
Comment 3•12 years ago
|
||
Oh sorry yeah forgot the WebGL tests did that.
Assignee | ||
Comment 4•12 years ago
|
||
On tryserver:
https://tbpl.mozilla.org/?tree=Try&rev=debabaa16a47
Should see mention of 'skipped' tests in android M1 log, but not on Mac.
Assignee | ||
Updated•12 years ago
|
Summary: On Android, disable WebGL conformance test directories that cause frequent timeouts → On Android, disable WebGL conformance tests that cause frequent timeouts
Assignee | ||
Updated•12 years ago
|
Attachment #680635 -
Flags: review?(jgilbert)
Assignee | ||
Comment 5•12 years ago
|
||
retriggered android m1 a bunch of times.
Assignee | ||
Comment 6•12 years ago
|
||
Green! (And blue, but that's OK). No orange.
Updated•12 years ago
|
Attachment #680635 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Assignee: nobody → bjacob
Target Milestone: --- → mozilla20
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•