Closed
Bug 811095
Opened 12 years ago
Closed 12 years ago
re-enable native Identity dialog
Categories
(Core Graveyard :: Identity, enhancement)
Core Graveyard
Identity
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)
People
(Reporter: jedp, Assigned: jedp)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
A changeset for 794680 was backed out due to a leak identified in bug 807078. The second application of the patch failed to include updates to jar.mn and Makefile.in files that are needed to enable identity on b2g
Comment 2•12 years ago
|
||
Comment on attachment 680798 [details] [diff] [review]
(re)enable identity components
Review of attachment 680798 [details] [diff] [review]:
-----------------------------------------------------------------
let's do this!
Attachment #680798 -
Flags: review?(benadida) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Ben Adida [:benadida] from comment #2)
> Comment on attachment 680798 [details] [diff] [review]
> (re)enable identity components
>
> Review of attachment 680798 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> let's do this!
I agree! It seems like a great idea! :)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #680798 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Updated•12 years ago
|
Blocks: basecamp-id
Comment 6•12 years ago
|
||
Still missing the user info in the patch, but at least it has a commit message :P
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3592db8b44
Keywords: checkin-needed
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6)
> Still missing the user info in the patch, but at least it has a commit
> message :P
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3592db8b44
Thanks for your patience, Ryan. I'm learning. Slowly :)
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•12 years ago
|
Whiteboard: [qa-]
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 680801 [details] [diff] [review]
(re)enable identity components
[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature
User impact if declined: native identity won't work
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low; isolated component
String or UUID changes made by this patch: none
Attachment #680801 -
Flags: approval-mozilla-beta?
Updated•12 years ago
|
Attachment #680801 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•12 years ago
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•