Closed Bug 811177 Opened 12 years ago Closed 11 years ago

document designMode does not bring up the keyboard

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: xyuan, Assigned: janjongboom)

References

(
URL
)

Details

(Whiteboard: [label:Keyboard & IME])

Attachments

(3 files, 2 obsolete files)

gaia_test_case.patch
(deleted), patch
Details | Diff | Splinter Review
Gecko patch v2
(deleted), patch
xyuan
: review+
Details | Diff | Splinter Review
Tests (need relanding)
(deleted), text/x-github-pull-request
janjongboom
: review+
Details 
If we set the designMode property to 'on', the entire document will be editable. The keyboard doesn't respond to such type of document.

Testcase provided Martijn Wargers [:mw22]:
 - http://people .mozilla.org/~mwargers/tests/contenteditable/designmode.htm
Can we fix this as soon as possible?  It is blocking the release of my app (https://github.com/joshua-s/firetext/).
Another way to set the entire document editable is letting document.designMode = “on”, which can't bring keyboard as well.
Blocks: keyboard-api
Severity: minor → normal
Component: Gaia::System → Gaia::Keyboard
I'll take a look.
Assignee: nobody → janjongboom
Attached patch Gecko patch (obsolete) (deleted) — — Splinter Review 
Here is a patch
Attachment #796100 - Flags: review?(xyuan)
Attached file Tests (obsolete) (deleted) — 

        Attachment #796102 -
        Flags: review?(xyuan)

    
    

    
  
Will the patch break bug 902168?
Status: NEW → ASSIGNED
Flags: needinfo?(janjongboom)

    
    

    
  
I don't think so, at least contenteditable kept working for me in both SMS as well as in the tests and I havent seen any messages, but it looks like it could break that yeah. I'll write a test case...
Flags: needinfo?(janjongboom)

    
    

    
  
I made a mistake in comment 2, and the other way to set the entire document editable should be:
 <body contenteditable>contentEditable</body>

    
    

    
  

      
      
      
      

        Attached patch
          
          
        gaia_test_case.patch (deleted)
        — 
          — Splinter Review
      

    


  
On b2g-desktop, the following test failed with gecko patch of Comment 4:

1. Apply gaia_test_case.patch to gaia
2. Launch b2g-desktop and open |UI Tests| -> |Empty|
3. Click the content text 'Hello World!', which is editable

Expected: 
The keyboard is launched.

Actual:
The keyboard won't show for the first time, but after open the keyboard with other input field and reproduce the above steps, the keyboard may show.

        Attachment #796100 -
        Flags: review?(xyuan)

    
    

    
  
The bug addressed in Comment 9 has to do with nested iframes (which is what we have in UI tests)... Will take a look.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Gecko patch v2 (deleted)
        — 
          — Splinter Review
      

    


  
Hi Yuan, the attached patch passes:

* iframe document with designMode=on (tests attached)
* iframe with body contenteditable (bug 902168) (tests attached)
* test case provided in gaia_test_case.patch

        Attachment #796100 -
        Attachment is obsolete: true

        Attachment #796568 -
        Flags: review?(xyuan)

    
    

    
  
Comment on attachment 796568 [details] [diff] [review]
Gecko patch v2

Review of attachment 796568 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Tested on device and b2g-desktop. The patch works fine.

        Attachment #796568 -
        Flags: review?(xyuan) → review+

    
    

    
  
Comment on attachment 796102 [details]
Tests

r=me. 

I don't actually run the test, but it looks good for me.

And could please also add a test page to UI tests app so that QA can help to verify the bug.

        Attachment #796102 -
        Flags: review?(xyuan) → review+

    
    

    
  
Added iframe tests to UI tests, and landed in https://github.com/mozilla-b2g/gaia/commit/53d993416233fd1f5de3976ac49c62f5ddc465af (needs gecko patch to have landed as well to be working of course)

    
    

    
  
Well done!
Depends on: 910761

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3f1133846836
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to Jan Jongboom [:janjongboom] from comment #14)
> Added iframe tests to UI tests, and landed in
> https://github.com/mozilla-b2g/gaia/commit/
> 53d993416233fd1f5de3976ac49c62f5ddc465af (needs gecko patch to have landed
> as well to be working of course)

Backed out due to this depends on the Gaia patch of Bug 906096, which is also backed out for new IME framework to land.

revert commit:
6e2767ebb2d34dc1511ce40914c813c7693a0f5c

    
    

    
  
Was not reopened when backing out...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        Tests (need relanding) (deleted)
        — 
      

    


  

        Attachment #796102 -
        Attachment is obsolete: true

        Attachment #802180 -
        Flags: review+

    
    

    
  
Relanded in https://github.com/mozilla-b2g/gaia/commit/6054a6230f6c4d5322f15b30c363b25dc186da58
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
Attachment mime type: text/plain → text/x-github-pull-request

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: