Closed
Bug 811328
Opened 12 years ago
Closed 12 years ago
Remove all references of 'Firefox' in Gaia code
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(blocking-basecamp:+)
People
(Reporter: clee, Assigned: vingtetun)
References
Details
(Keywords: late-l10n, Whiteboard: QARegressExclude)
Attachments
(1 file)
(deleted),
patch
|
kaze
:
review+
|
Details | Diff | Splinter Review |
The purpose of this bug is to remove all references of 'Firefox' in the OS code base.
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → 21
blocking-basecamp: --- → +
Priority: -- → P1
Comment 1•12 years ago
|
||
Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.
Target Milestone: --- → B2G C2 (20nov-10dec)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #686138 -
Flags: review?(kaze)
Assignee | ||
Comment 4•12 years ago
|
||
I still have some images to change but I need unofficial assets for them. Adding Patryk, Josh to the list.
There will still be some links that contains the string but that's the same for the Firefox browser so I'm not sure that's a real problem.
Flags: needinfo?(padamczyk)
Flags: needinfo?(jcarpenter)
Comment 5•12 years ago
|
||
Comment on attachment 686138 [details] [diff] [review]
Patch
Review of attachment 686138 [details] [diff] [review]:
-----------------------------------------------------------------
Hoah, outstanding work, thanks Vivien. I was worried about this bug and I'm happy that we're able to fix it so quickly.
::: shared/locales/branding.ini
@@ +1,1 @@
> +@import url(branding/branding.en-US.properties)
ini files support key-value pairs, so I think we should just put the contents of branding.en-US.properties in here and remove all other per-locale sections.
I don't think we'll want to change branding per locale?
Comment 6•12 years ago
|
||
Comment on attachment 686138 [details] [diff] [review]
Patch
Review of attachment 686138 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, assuming that you’ll revert the FTU + OOP changes in window_manager.js before merging.
::: Makefile
@@ +269,4 @@
> const GAIA_APP_SRCDIRS = "$(GAIA_APP_SRCDIRS)"; \
> const GAIA_LOCALES_PATH = "$(GAIA_LOCALES_PATH)"; \
> const BUILD_APP_NAME = "$(BUILD_APP_NAME)"; \
> + const PRODUCTION = "$(PRODUCTION)"; \
nit: the trailing backslash is not aligned vertically.
::: apps/system/js/window_manager.js
@@ +777,4 @@
> // reference to the app and launch it.
> function retrieveFTU() {
> window.asyncStorage.getItem('ftu.enabled', function getItem(launchFTU) {
> + if (false) {
you probably don’t want to merge this workaround. ;-)
@@ +945,4 @@
> }
> }
>
> + var isOutOfProcessDisabled = true;
same here
Attachment #686138 -
Flags: review?(kaze) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/1e830e4277894dd3db1e4c658e25d6dccf3f099a
I opened a followup for the images.
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(padamczyk)
Flags: needinfo?(jcarpenter)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•