Closed Bug 811328 Opened 12 years ago Closed 12 years ago

Remove all references of 'Firefox' in Gaia code

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(blocking-basecamp:+)

RESOLVED FIXED
B2G C2 (20nov-10dec)
blocking-basecamp +

People

(Reporter: clee, Assigned: vingtetun)

References

Details

(Keywords: late-l10n, Whiteboard: QARegressExclude)

Attachments

(1 file)

The purpose of this bug is to remove all references of 'Firefox' in the OS code base.
Assignee: nobody → 21
blocking-basecamp: --- → +
Priority: -- → P1
Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.
Target Milestone: --- → B2G C2 (20nov-10dec)
Keywords: late-l10n
I still have some images to change but I need unofficial assets for them. Adding Patryk, Josh to the list. There will still be some links that contains the string but that's the same for the Firefox browser so I'm not sure that's a real problem.
Flags: needinfo?(padamczyk)
Flags: needinfo?(jcarpenter)
Comment on attachment 686138 [details] [diff] [review] Patch Review of attachment 686138 [details] [diff] [review]: ----------------------------------------------------------------- Hoah, outstanding work, thanks Vivien. I was worried about this bug and I'm happy that we're able to fix it so quickly. ::: shared/locales/branding.ini @@ +1,1 @@ > +@import url(branding/branding.en-US.properties) ini files support key-value pairs, so I think we should just put the contents of branding.en-US.properties in here and remove all other per-locale sections. I don't think we'll want to change branding per locale?
Comment on attachment 686138 [details] [diff] [review] Patch Review of attachment 686138 [details] [diff] [review]: ----------------------------------------------------------------- r=me, assuming that you’ll revert the FTU + OOP changes in window_manager.js before merging. ::: Makefile @@ +269,4 @@ > const GAIA_APP_SRCDIRS = "$(GAIA_APP_SRCDIRS)"; \ > const GAIA_LOCALES_PATH = "$(GAIA_LOCALES_PATH)"; \ > const BUILD_APP_NAME = "$(BUILD_APP_NAME)"; \ > + const PRODUCTION = "$(PRODUCTION)"; \ nit: the trailing backslash is not aligned vertically. ::: apps/system/js/window_manager.js @@ +777,4 @@ > // reference to the app and launch it. > function retrieveFTU() { > window.asyncStorage.getItem('ftu.enabled', function getItem(launchFTU) { > + if (false) { you probably don’t want to merge this workaround. ;-) @@ +945,4 @@ > } > } > > + var isOutOfProcessDisabled = true; same here
Attachment #686138 - Flags: review?(kaze) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(padamczyk)
Flags: needinfo?(jcarpenter)
Resolution: --- → FIXED
Whiteboard: QARegressExclude
Depends on: 1175572
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: