Closed Bug 811429 Opened 12 years ago Closed 11 years ago

Work - filled view of Firefox Start should be scrollable with mouse wheel

Categories

(Firefox for Metro Graveyard :: Input, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Input
Platform:
All
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ally, Assigned: rsilveira)

References

Details

(Keywords: dogfood, qawanted, Whiteboard: feature=work)

Attachments

(1 file)

Patch v1
(deleted), patch
mbrubeck
: review+
Details | Diff | Splinter Review
after talking with yuan, and in the progress of adding topsites, it is clear that about:home/awesome screen should be scrollable in filled view
I imagine it will qualify for mvp, as it prevents access to much of the page. sending to triage
Whiteboard: [metro-mvp?]
Blocking, we need to test to be sure this is still broken.
Whiteboard: [metro-mvp?] → [metro-mvp]
OS: Mac OS X → Windows 8 Metro
Whiteboard: [metro-mvp] → [metro-mvp] feature=work
Blocks: 831920
No longer blocks: 747789
Summary: filled view of start screen should be scrollable → Work - filled view of start screen should be scrollable
Whiteboard: [metro-mvp] feature=work → feature=work
Summary: Work - filled view of start screen should be scrollable → Work - filled view of Firefox Start should be scrollable
Touch scrolling was fixed in bug 828096. Mouse/pen scrolling for all scroll views is covered by bug 775718. The remaining case is mouse-wheel scrolling. I'll morph this bug to cover that, since the Firefox Start screen is a special case. (The wheel should scroll it horizontally rather than vertically, just like the Windows start screen.)
Component: General → Input
Hardware: x86 → All
Summary: Work - filled view of Firefox Start should be scrollable → Work - filled view of Firefox Start should be scrollable with mouse wheel
Priority: -- → P4
As much as I love mice, this is marked p4. Asa, before I start work on it, do you still want this in v1?
Flags: needinfo?(asa)
Priority: P4 → P2
Yes, please.
Flags: needinfo?(asa)
Blocks: 867929
No longer blocks: 867929
This would help with community testing efforts by making it easier to use Metro without touch hardware. Marking qawanted + dogfood.
Keywords: dogfood, qawanted
Attached patch Patch v1 (deleted) — — Splinter Review
It's working great in -metrodesktop mode, but it's pretty slow scrolling in metro mode. Not sure why yet.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #756230 - Flags: review?(mbrubeck)
Comment on attachment 756230 [details] [diff] [review] Patch v1 I wonder if the Metro widget pixel scroll events are off - maybe similar to bug 829952.
Attachment #756230 - Flags: review?(mbrubeck) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #8) > Comment on attachment 756230 [details] [diff] [review] > Patch v1 > > I wonder if the Metro widget pixel scroll events are off - maybe similar to > bug 829952. I'm not sure if we send pixel scroll. Tim most of the input work in widget, cc'ing him.
We only send "line" wheel events, not "pixel" wheel events; see [2]. If we want pixel scroll, we'll have to do something similar to [1]. This should be a pretty simple change. [1] https://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsChildView.mm?rev=53afe9fba5c0#4428 [2] https://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/MetroInput.cpp?rev=43872f1bfbda#494
The patch I submitted is not really about filled view, I created bug 879570 for what this is actually fixing! Opened bug 879562 about the pixel scroll mentioned on comment 10.
Whiteboard: feature=work → feature=work [preview-triage]
The patch for Bug 879570 fixed this.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Whiteboard: feature=work [preview-triage] → feature=work
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: