Closed
Bug 811528
Opened 12 years ago
Closed 12 years ago
Native identity needs to be preffed on in b2g
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(blocking-basecamp:+, firefox19 wontfix, firefox20 fixed, firefox21 fixed, b2g18 fixed)
People
(Reporter: jedp, Assigned: jedp)
References
Details
Attachments
(2 files)
Native identity needs to be preffed on in b2g by default. The pref is: pref("dom.identity.enabled", true);
Comment 1•12 years ago
|
||
Before preffing on, I'd like to get a quick test pass with John & I to see if nothing scary showing up. I'd also like to wait until the id.get bug lands before doing that pass. Does that make sense? Just trying to be careful since when we pref this on, native identity will go into a smoke test, so if there's bustage in a smoke test on a daily basis, then it will get red flagged in front of lots of people. I'd rather go conservative if it's possible to catch any surprises early.
Blocks: basecamp-id
Severity: enhancement → normal
status-firefox18:
fixed → ---
status-firefox19:
fixed → ---
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #1) > Before preffing on, I'd like to get a quick test pass with John & I to see > if nothing scary showing up. I'd also like to wait until the id.get bug > lands before doing that pass. > > Does that make sense? > > Just trying to be careful since when we pref this on, native identity will > go into a smoke test, so if there's bustage in a smoke test on a daily > basis, then it will get red flagged in front of lots of people. I'd rather > go conservative if it's possible to catch any surprises early. That's totally reasonable. While we're developing, it's easy enough to push the pref to the device when necessary.
Assignee | ||
Comment 3•12 years ago
|
||
For those reading this who are wondering how to pref it on in the phone, it's like this: 1. Edit profile/user.js in your gaia build and add pref("dom.identity.enabled", true); pref("toolkit.identity.debug", true); // If you want logging 2. Push to the device: adb push profile/user.js /data/local/ 3. Reboot adb reboot Notice that the custom-pref.js file does *not* go to the device. So while that works on desktop, it is currently not seen by the phone.
Comment 4•12 years ago
|
||
Jed, if you're not the correct owner here, please re-assign.
Assignee: nobody → jparsons
Comment 5•12 years ago
|
||
Putting qawanted on me cause this hasn't been prefed on by default cause it's waiting on qa verification.
Keywords: qawanted
QA Contact: jsmith
Comment 6•12 years ago
|
||
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
Comment 7•12 years ago
|
||
Spoke with Jed - We're going to instead pref on once the id.get bug lands and do testing with it prefed on. If something scary happens, we'll handle it as needed.
Keywords: qawanted
Assignee | ||
Comment 8•12 years ago
|
||
Submitted gaia pull request: https://github.com/mozilla-b2g/gaia/pull/6845
Keywords: qawanted
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #7) > Spoke with Jed - We're going to instead pref on once the id.get bug lands > and do testing with it prefed on. If something scary happens, we'll handle > it as needed. id.get: That would be Bug 790141 - this actually landed some two weeks ago; it just needs a separate patch to apply to beta. I'm working on that now. Thanks! j
Comment 11•12 years ago
|
||
Jed, don't forget to add a link to the PR or attach the patch to the bug and ask for review, please :). I've commented the PR in Github.
Comment 12•12 years ago
|
||
In order to cleanly pref on without smoke test bustage, we need to be able to login with persona without a headache. The two bugs linked currently have me blocked from being able to complete a login. So if we pref on at this point, they will move to becoming smoketest blockers.
Assignee | ||
Comment 13•12 years ago
|
||
Enable native dom identity calls in gecko There's a corresponding PR in gaia (other attachment pointing to PR 6845) which switches on identity debugging if `DEBUG=` when building gaia. It's ok if one patch lands before the other; they're not interdependent.
Attachment #690528 -
Flags: review?(ferjmoreno)
Assignee | ||
Comment 14•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #12) > In order to cleanly pref on without smoke test bustage, we need to be able > to login with persona without a headache. The two bugs linked currently have > me blocked from being able to complete a login. So if we pref on at this > point, they will move to becoming smoketest blockers. Hi, Jason, no problem waiting until those issues are sorted out. In the mean time, I'm requesting approval on the patch and corresponding gaia PR so they're ready to go when these blockers are fixed.
Comment 15•12 years ago
|
||
Comment on attachment 690528 [details] [diff] [review] pref identity on in gecko Thanks Jed!
Attachment #690528 -
Attachment is patch: true
Attachment #690528 -
Flags: review?(ferjmoreno) → review+
Updated•12 years ago
|
Attachment #689620 -
Flags: review+
Comment 16•12 years ago
|
||
Just for simplicity - we'll just want to get the smoketest for this feature to pass and then we can land this.
Assignee | ||
Comment 17•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #16) > Just for simplicity - we'll just want to get the smoketest for this feature > to pass and then we can land this. Sounds good.
Comment 18•12 years ago
|
||
I confirmed I can sign into marketplace dev with the patch Kumar provided with this prefed on. Doesn't look like that code has been pushed to production yet though. Kumar - Do you know when the patch for bug 821351 will end up production?
Flags: needinfo?(kumar.mcmillan)
Comment 19•12 years ago
|
||
It will reach production on Thurs Jan 3rd, our next push. I'm currently using the notoriousb2g.personatest.org server -- let me know when we can change it to prod. Changing the URL is a minor config change and can be done at any time.
Flags: needinfo?(kumar.mcmillan)
Comment 20•12 years ago
|
||
Sticking something in the whiteboard to remind me to test this when I get back "officially"
Whiteboard: [Note - Do signoff testing on this on Jan 3rd]
Comment 21•12 years ago
|
||
Late night tonight I took a quick look on dev - didn't see anything scary on marketplace dev. Assuming the same story happens on prod, I'm expecting I can sign off to pref this on after the marketplace prod push + quick sanity checks.
Updated•12 years ago
|
Target Milestone: B2G C3 (12dec-1jan) → B2G C4 (2jan on)
Comment 22•12 years ago
|
||
Okay - looks like the prod has the b2g fixes in. Signoff testing has just started to sanity check this to be okay to pref on.
Comment 23•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #22) > Okay - looks like the prod has the b2g fixes in. Signoff testing has just > started to sanity check this to be okay to pref on. Alright, someone needs to land this patch.
Keywords: qawanted
Whiteboard: [Note - Do signoff testing on this on Jan 3rd]
Updated•12 years ago
|
Keywords: checkin-needed
Comment 25•12 years ago
|
||
Marketplace login is going to be busted each day now if this isn't landed. We need to get this landed asap in gecko, but I don't have checkin power. Ryan - Can you get this landed?
Flags: needinfo?(ryanvm)
Comment 26•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ddd8c0cb44
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Comment 27•12 years ago
|
||
Landed on B2G18 at jsmith's request: https://hg.mozilla.org/releases/mozilla-b2g18/rev/762e339e11c3 I corrected the comment typo and whitespace in that landing, which I've then also applied to trunk in: https://hg.mozilla.org/integration/mozilla-inbound/rev/0df826490fc0
status-b2g18:
--- → fixed
status-firefox20:
--- → fixed
Comment 30•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/49ddd8c0cb44 https://hg.mozilla.org/mozilla-central/rev/0df826490fc0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 31•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #29) > Don't forget to land it on Aurora also. Adding checkin-needed for aurora (I have a meeting now). Side note: Now that we're shipping B2G off of b2g18 do we even need B2G builds on aurora any more (until such time as we get closer to the next b2gNN fork)?
Keywords: checkin-needed
Whiteboard: [checkin-needed for aurora]
Comment 32•12 years ago
|
||
(In reply to Ed Morley [:edmorley UTC+0] from comment #31) > Side note: Now that we're shipping B2G off of b2g18 do we even need B2G > builds on aurora any more (until such time as we get closer to the next > b2gNN fork)? It was decided this morning that uplifts only need to hit b2g18 these days, so nothing else needs to be done here. Not sure if there's a bug filed about not running b2g builds on Aurora, though.
Comment 33•12 years ago
|
||
Verified - builds are getting identity prefed on by default.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
status-firefox21:
--- → fixed
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•