Jan de Mooij [:jandem] Assignee
	Description • 12 years ago

Handling CALLLOCAL/CALLARG will be useful to test the IC design and frame iteration code.

	Jan de Mooij [:jandem] Assignee
	Comment 1 • 12 years ago

Handles calls using Invoke. Introduces a bunch of new jit-test failures, seems to be mostly frame iteration stuff, will look into them tomorrow.

	Jan de Mooij [:jandem] Assignee
	Comment 2 • 12 years ago

On top of the patch in bug 812138, this doesn't introduce any new jit-test failures on x86 and x64.

	Kannan Vijayan [:djvj]
	Comment 3 • 12 years ago

Comment on attachment 681962 [details] [diff] [review]
Patch

Review of attachment 681962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

I think we should eliminate the coding of constructing flag into the key.  The DoCallFallback function can inspect the JSOp at the PC to do the right thing, as well as to decide what kind of specific optimized stubs it wants to generate in the future - e.g. it can generate ICNew_Blah vs. ICCall_Blah depending on the inspected JSOp value.  Maybe we can rename ICCall_Fallback to ICInvoke_Fallback to represent the fact that it handles both Call and New cases.

Currently the extra argument makes it non-uniform with the style of the rest of the fallback ICs and doesn't provide any new information that we can't access from DoCallFallback anyway, and I don't see a significant perf benefit to doing this either.

	Jan de Mooij [:jandem] Assignee
	Comment 4 • 12 years ago

Adds NEW and uses a single fallback function.

	Kannan Vijayan [:djvj]
	Comment 5 • 12 years ago

Comment on attachment 682061 [details] [diff] [review]
Part 2: Handle NEW

Review of attachment 682061 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet :)

	Jan de Mooij [:jandem] Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/projects/ionmonkey/rev/420892dc7b4d
https://hg.mozilla.org/projects/ionmonkey/rev/4415df1167d3