Closed
Bug 812103
Opened 12 years ago
Closed 12 years ago
TBPL should recognise MSVC errors ("error C0000:" and "error RC0000:")
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sheriff-want])
Attachments
(1 file)
(deleted),
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
Originally mentioned on bug 778688, split out here:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=17050738&tree=Thunderbird-Trunk
> {
> e:/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mail/app/module.rc(40) :
> error RC2135 : file not found: address-book.ico
> }
>
> (building a resource file on Windows).
> https://tbpl.mozilla.org/php/getParsedLog.php?id=17052870&tree=Thunderbird-Trunk
> {
> e:/builds/moz2_slave/tb-c-cen-w32/build/calendar/base/src/calDateTime.cpp(633)
> : error C2660: 'js::UnwrapObjectChecked' : function does not take 2 arguments
> }
Attaching patch which should fix tbpl for these, though I've not actually tested it.
Attachment #681896 -
Flags: review?(bmo)
Comment 1•12 years ago
|
||
Comment on attachment 681896 [details] [diff] [review]
The fix
Tried testing locally, but couldn't find an instance of this failure type.
Anyway looks good & nothing blew up, so happy to land and see how it goes :-)
Thank you for doing this!
Attachment #681896 -
Flags: review?(bmo) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•