Closed
Bug 81237
Opened 24 years ago
Closed 23 years ago
IRC Chat has bizarre menu position
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: mpt, Assigned: nnooiissee)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Build: 2001051504, Mac OS 9.1
To reproduce:
* Open the `Tasks' menu.
What you see:
Navigator accel+1
Mail/News accel+2
Composer accel+4
Address Book accel+5
---------------------------------
Privacy and Security >
---------------------------------
IRC Chat accel+8
...
What you should see:
Navigator accel+1
Mail/News accel+2
IRC Chat accel+3
Composer accel+4
Address Book accel+5
---------------------------------
Privacy and Security >
---------------------------------
...
It makes no sense for the accel+3 `hole' to be empty, and for IRC Chat to be
placed separately from the rest of the Mozilla apps with a seemingly-random
accel+8 keyboard shortcut.
Comment 1•24 years ago
|
||
I think this "hole" is used for NS6.x for the AIM messenger or something...
OS: Mac System 9.x → All
Hardware: Macintosh → All
Comment 3•24 years ago
|
||
Comment 4•24 years ago
|
||
looks ok to me. sr=ben@netscape.com
Comment 6•24 years ago
|
||
r=doron
Comment 7•24 years ago
|
||
drivers emailed for approval.
Comment 9•24 years ago
|
||
Why would it?
Comment 10•24 years ago
|
||
I think NS should be fine if they hide the chatzilla menuitem by id=""... My
patch only moves the item to a new position
Comment 11•24 years ago
|
||
After talking with hwaara on IRC it looks like this should have zero impact on
the NS commercial menuitems.
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Comment 12•24 years ago
|
||
Ok, so we hit some problems. Apparently, the Tasks menu automatically sets the
key (e.g., Ctrl+3) by the position of the menuitem. So because my fix changed
the position of the "IRC Client" item to position 3 - it also changed its key.
That means that for the Commercial builds, where they have the IM client as item
3 - if you have both IM and Chatzilla installed you'll get two menuitems with
the same key.
An easy workaround would be to set Chatzilla as item 6 (right after the
addressbook), but that wouldn't solve the key "hole" we are experiencing in
Mozilla builds.
Asa told me that Rob Ginda might be able to help out with a solution here. cc rginda
Updated•24 years ago
|
Component: XP Apps: GUI Features → chatzilla
Comment 14•24 years ago
|
||
sorry for the delay...only recently returned to the trunk...in any case, the
current fix isn't good on commercial builds.
i'm reopening this --but let me know if it's best to keep this resolved and file
a separate bugscape report. perhaps IRC Chat shouldn't be built in the
commercial product for linux? [see results below --IRC Chat isn't present in the
mac or win32 comm bits, afaik. dunno why.]
results:
linux comm 2001.06.19.08 --both Tasks > IRC Chat and Tasks > Instant Messenger
have Ctrl+3. hitting Ctrl+3 brings up Instant Messenger.
winnt comm 2001.06.19.11 and mac comm 2001.06.19.08 --n/a: IRC Chat isn't listed
in the Tasks menu
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•24 years ago
|
QA Contact: sairuh → mozilla
Comment 15•24 years ago
|
||
I knew about this case when checking in, but got go-ahead from Asa, Ben, Kerz
and Rginda because they said that Chatzilla is not installed by default anyway...
If you still want it fixed (probably you will) then file it as a separate
bugscape report. Thanks
Comment 16•24 years ago
|
||
i've filed http://bugscape.mcom.com/show_bug.cgi?id=6615 so that chatzilla
doesn't get into the commercial bits like that.
re-resolving as fixed. thx, hakan!
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•24 years ago
|
||
In build 2001062105 (yeah, I know it's old, but it's from a long time after
this bug was fixed), on Mac OS 9.1, I have the following:
Navigator accel+1
Mail/News accel+2
Composer accel+4
IRC Chat accel+3
Address Book accel+5
Close, but no cigar. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 18•24 years ago
|
||
On build 20010620 (the day before mpt's build was made), it is correct. Has been
working for me ever since the checkin was done...
Comment 19•24 years ago
|
||
hwaara, I think that this has been wrong on mac and right on win32 and linux.
Comment 20•24 years ago
|
||
But how? chatzillaOverlay.xul is XP
Comment 21•24 years ago
|
||
Can anyone else on Mac confirm this behaviour?
Comment 22•24 years ago
|
||
yep, i'm seeing what mpt saw using 2001.07.03.10-trunk mozilla bits on mac.
Comment 23•24 years ago
|
||
Pinkerton, you're XPMenu and Mac master. Any idea why this *can* be happening?
I didn't think these things were able to happen in XP code.
Comment 24•24 years ago
|
||
I have no idea at all how to fix this mac-only bug (works just fine on Linux and
Windows). I'm sorry. :(
I'll reassign this to XPApps.
Assignee: hwaara → pchen
Status: REOPENED → NEW
Component: chatzilla → XP Apps
QA Contact: mozilla → sairuh
Comment 25•23 years ago
|
||
Umm, 2001-08-13-06-trunk mac classic build seems fine and my opt mac classic
build from trunk a few days ago looks ok, too. Marking fixed
Status: NEW → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Comment 26•23 years ago
|
||
vrfy fixed using 2001.11.06.08-mozilla bits on mac os 10.1 --IRC Chat [cmd+3] is
properly btwn Mail & Newsgroups [cmd+2] and Composer [cmd+4] in the Tasks menu.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 27•23 years ago
|
||
Reopening. Both 2001112708 on Mac OS, and 0.9.6 on Windows, have the `IRC Chat'
item as the fifth (last) item in the group, when it should be the third.
Status: VERIFIED → REOPENED
OS: Mac System 9.x → All
Hardware: Macintosh → All
Resolution: FIXED → ---
Summary: IRC Chat has bizarre menu position and keyboard shortcut → IRC Chat has bizarre menu position
Comment 29•23 years ago
|
||
poss. infrastructure bug? ->xpt menus
Assignee: trudelle → hyatt
Component: XP Apps → XP Toolkit/Widgets: Menus
QA Contact: sairuh → jrgm
Assignee | ||
Comment 30•23 years ago
|
||
this is fixed with the patches in bug 109598. i think andreww is going to review
when he gets back. he said he owns a bugscape bug which should be fixed by that
as well.
if anyone wants to r/sr the patches in bug 109598, feel welcome to.
btw, the underlying problem is that different ports seem to load components in
different orders. most load messanger first, then chatzilla, but mac os classic
(not x) loads chatzilla first. nasty little situation, but the solution is to
ignore it and not to use position=.
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Comment 32•23 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•