Closed Bug 812527 Opened 12 years ago Closed 11 years ago

Camera: 2 second image preview after taking photo is too long

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

All
Other
defect
Not set
normal

Tracking

(blocking-basecamp:-)

RESOLVED INVALID
blocking-basecamp -

People

(Reporter: pla, Unassigned)

References

Details

(Whiteboard: UX-P2, interaction)

Attachments

(3 files, 1 obsolete file)

Go to camera app and take a photo. There are several things wrong with the experience: 1. It takes 3-4 seconds to take a photo, from when I press the button to when I can take another picture. As a comparison, I can take 3 photos on iPhone in the same amount of time. 2. The visual feedback looks sluggish because of the overall speed. 3. It currently displays a distorted random collection of green/white pixels at the point of image capture (this is where on iPhone an shutter animation is rendered). There needs to be a visual feedback rendered during image capture. There is a bug logged against Visual Design to design this (812525).
QA Contact: dclarke
Tested on Nov. 15 Unagi nightly build.
Keywords: polishperf
Whiteboard: visual design
Component: Gaia → Gaia::Camera
Priority: -- → P2
Rewriting using the performance/ux-trust bug template. -- What makes it feel slow/broken? It seems to take longer than I want to snap a photo. Currently, it takes 4+ seconds to take one photo. Also, there is non animation when the photo is being taken, but on Unagi there are white/green streaks that basically look like an error occured (filed as bug 812525). Did it prevent you from doing what you wanted? Why? No, it didn't prevent me from taking a photo. But it could prevent me from taking a series of photos of something in action. Or I could miss a moment in time that I wanted to capture. How does this make you feel? [ ] :) I feel happy about it [ ] :| Meh [X] :( I'm upset [ ] >:O I'm angry Device: Unagi, Nov. 22 Nightly. Details: It takes 4+ seconds to take a photo on B2G/Unagi. It takes 2 seconds to take a photo on Android ICS/Otoro. Bonus: can you attach a video of the problem? Yes
Keywords: ux-trust
Summary: [Gaia][perf] Camera experience feels sluggish when snapping a photo → [Gaia::Camera][perf][ux-trust] Camera experience feels sluggish when snapping a photo
Priority: P2 → P1
Summary: [Gaia::Camera][perf][ux-trust] Camera experience feels sluggish when snapping a photo → [Gaia::Camera] Camera experience feels sluggish when snapping a photo
Attached video Taking a photo - B2G (deleted) —
Attached video Taking a photo - Android (deleted) —
Keywords: ux-trust
Priority: P1 → --
Summary: [Gaia::Camera] Camera experience feels sluggish when snapping a photo → Camera experience feels sluggish when snapping a photo
Whiteboard: UX-P1
This is a core use case and needs to be rock solid, and current times are not acceptable for launch, so am nominating for blocking in order to ensure resources are allocated to addressing.
blocking-basecamp: --- → ?
This is only reproducible on unagi. And unagi is not our final shipping device. Our partner said they will not solve that issue. We are open to another UX proposition to solve that.
blocking-basecamp: ? → -
Flags: needinfo?(jcarpenter)
Can we get QA verification that this is not an issue on Otoro before we close this bug?
Flags: needinfo?(jcarpenter)
Keywords: qawanted
Whiteboard: UX-P1 → UX-P?
(In reply to Josh Carpenter [:jcarpenter] from comment #7) > Can we get QA verification that this is not an issue on Otoro before we > close this bug? Lets get feedback from David.
Flags: needinfo?(dclarke)
Dupe of bug 799801?
Whiteboard: UX-P? → [UX-P?][DUPEME? 799801]
I don't have an otoro device or build with which to duplicate this, we can revisit this when we have phones that accurately mimic shipping hardware..
Flags: needinfo?(dclarke)
Would have to build otoro from scratch, and since no one is testing on it I don't know if what i would have was an accurate production build.. Generally I'd just be guessing, and the eventuality is that until we have production hardware, and production builds for that hardware, making a qualification one way or another would be hard. If unagi has a hardware issue then we should see it on Android ICS / Unagi ?
Keywords: qawanted
The green/white pixel noise between snapping photos is a major user experience issue. If I were a first-time FirefoxOS phone owner, I would think the camera was defective in my device and try to exchange it.
Whiteboard: [UX-P?][DUPEME? 799801] → [DUPEME? 799801], UX-P2, interaction
Blocks: 835367
Depends on: 836782
I investigated about "green/white pixel noise". It seems that it happens when aspect ratios of "camera preview" and "camera thumbnail" is different. "camera thumbnail" is drawn to "camera preview" by camera hw hal, when taking a photo.
It is just temporary workaround patch to address "green/white pixel noise" problem. I confirmed that it is fixed on Otoro device.
(In reply to Sotaro Ikeda [:sotaro] from comment #14) > Created attachment 708797 [details] [diff] [review] > Temporary patch: set picture size to preview size > > It is just temporary workaround patch to address "green/white pixel noise" > problem. I confirmed that it is fixed on Otoro device. It is better that the problem to be prevented also on gecko side.
Comment on attachment 708797 [details] [diff] [review] Temporary patch: set picture size to preview size The patch do not work for first time preview start. It is necessary to find other way.
Attachment #708797 - Attachment is obsolete: true
By this temporary change, "green/white pixel noise" problem is fixed. Even within same aspect ratio, only few preview settings could prevent the problem.
(In reply to Sotaro Ikeda [:sotaro] from comment #17) > Created attachment 708920 [details] [diff] [review] > Temporary patch: set picture preview size to 640 * 480 > > By this temporary change, "green/white pixel noise" problem is fixed. Even > within same aspect ratio, only few preview settings could prevent the > problem. I confirmed it only on unagi device.
Aside from the pixel noise (which is a known driver issue), we've done a lot of work on improving camera performance lately. Part of what you're seeing is that the Camera app intentionally holds the last-taken photo on the screen for 2 seconds[1]. If we think this delay is too long/unnecessary, we can change/remove it. 1. https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L174
Flags: needinfo?(pla)
Hi Mike, I do feel the delay is unnecessary, or perhaps a very small delay would be ok. As a rule of thumb, anything longer than 1 sec. should require a spinner, so we definitely should be below 1 second if there is a delay. I recommend trying no delay, seeing how that feels, and then slowly add more delay, up to 500ms. Can we try this? As a comparison, neither my Nexus 4 or iPhone 4 have any noticeable delay. If you really need to check on the quality of your photo, you can tap on the thumbnail.
Flags: needinfo?(pla)
Peter, if you're comfortable with modifying Gaia apps and reloading your device, you can try different values on your own. Just change the value noted above in comment 19, then from $B2G/gaia, type 'make install-gaia' to push the changes to your DUT. Curious: who has the final say on a change like this?
Whiteboard: [DUPEME? 799801], UX-P2, interaction → [c= p= s= u=] [DUPEME? 799801], UX-P2, interaction
Hema, see Mike's comment #19 and comment #21. Passing this to Media to make the decision on this change.
Flags: needinfo?(hkoka)
Keywords: perf
Summary: Camera experience feels sluggish when snapping a photo → Camera: 2 second image preview after taking photo is too long
Whiteboard: [c= p= s= u=] [DUPEME? 799801], UX-P2, interaction → UX-P2, interaction
We can close this ancient bug. I just looked in camera.js master and the delay from comment 19 doesn't exist any more.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Flags: needinfo?(hkoka)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: