Bobby Holley (:bholley) Assignee
	Description • 12 years ago

XPConnect currently has some hooks for comparing objects by comparing the underlying identity object. But since compartment-per-global, we can only ever have at most one XPCWN for a given identity object in a given compartment, so there's no way this hook would ever do anything. Let's kill it.

Jorendorff/Luke, is this something we're interested in removing on the JSAPI side as well? Or is it used by embedders?

	Luke Wagner [:luke]
	Comment 1 • 12 years ago

I seem to recall it was only added for the Mozilla embedding, so I'd be pro-removing it.  I think this would introduce some nice engine simplifications as well.

	Bobby Holley (:bholley) Assignee
	Comment 2 • 12 years ago

(In reply to Luke Wagner [:luke] from comment #1)
> I seem to recall it was only added for the Mozilla embedding, so I'd be
> pro-removing it.  I think this would introduce some nice engine
> simplifications as well.

Ok, file a followup bug dependent on this one? I'm probably not the right person to maximally reap the simplifications here.

	Blake Kaplan (:mrbkap) (inactive)
	Comment 5 • 12 years ago

Comment on attachment 710644 [details] [diff] [review]
Remove XPConnect equality hooks. v3

I guess we should thank gal for holding the line here on proxies and forcing us to ween XPConnect off of this hook.

	Bobby Holley (:bholley) Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/88543d623c3f

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/88543d623c3f