Closed
Bug 81268
Opened 24 years ago
Closed 7 years ago
Investigate possible issues with recursive reflows
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
INCOMPLETE
Future
People
(Reporter: attinasi, Unassigned)
References
Details
(Keywords: perf, Whiteboard: dupme)
While investigating another problem, I put a check in nsFrame::WillReflow to
assert if the frame is already in a reflow. Strangely, this assert gets
triggered whenever I pop up a XUL-based dialog (preferences dialog in browser,
or table dialog in Composers, for example).
I cannot understand yet if we support recursive reflows in some cases, all
cases, or if this is a bug. The frame in question is always the ViewportFrame.
Here is the code I added:
NS_IMETHODIMP
nsFrame::WillReflow(nsIPresContext* aPresContext)
{
#ifdef DEBUG
if (0 != (mState & NS_FRAME_IN_REFLOW)) {
NS_ASSERTION(0 == (mState & NS_FRAME_IN_REFLOW),
"frame is already in reflow");
nsresult rv = NS_OK;
}
#endif
NS_FRAME_TRACE_MSG(NS_FRAME_TRACE_CALLS,
("WillReflow: oldState=%x", mState));
mState |= NS_FRAME_IN_REFLOW;
return NS_OK;
}
This bug is a reminder to investigate this...
Updated•23 years ago
|
Target Milestone: --- → mozilla1.0.1
Reporter | ||
Comment 2•23 years ago
|
||
Moving Mozilla 1.01 bugs to 'future' milestone with priority P1
I will be pulling bugs from 'future' milestones when scheduling later work.
Priority: -- → P1
Target Milestone: mozilla1.0.1 → Future
Comment 3•22 years ago
|
||
Think this problem has been mentioned elsewhere in the meantime, but cannot
remember where ... hm.
Updated•22 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Whiteboard: dupme
Comment 4•22 years ago
|
||
Can someone help, as mentioned in comment #3 ?
Comment 5•22 years ago
|
||
Reassigning to other@layout.bugs for now until someone is willing to take it.
Assignee: attinasi → other
Target Milestone: Future → ---
Updated•22 years ago
|
Priority: P1 → P3
Target Milestone: --- → Future
Updated•15 years ago
|
Assignee: layout → nobody
QA Contact: chrispetersen → layout
Comment 6•7 years ago
|
||
nsFrame::WillReflow no longer exists.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•