Jonas Sicking (:sicking) No longer reading bugmail consistently Reporter
	Description • 12 years ago

+++ This bug was initially created as a clone of Bug #810780 +++

From bug 810780 comment 7:

Alarms:
- When the alarm rings, pressing the volume rocker should dismiss the alarm.

This likely needs to be fixed in the alarm app somehow since the system app has no way of communicating to the alarm app that it should be silenced.

However the alarm app has no access to the events fired for the volume buttons currently.

	Gene Lian (I already quit Mozilla)
	Comment 1 • 12 years ago

Hi Alive,

I don't quite understand why we need Alarm API's supports here. The Alarm API is only in charge of setting alarm time, firing it on time and notifying apps through system message, which should have nothing to do with the ringing alarm dismissing. Isn't that completely a Gaia-end issue? I could be wrong. Please feel free to correct me. Thanks!

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 2 • 12 years ago

As Jonas said, we don't have a proper way to dismiss alarm from system app. System app doesn't know who is alarm app to dismiss or close when alarm sounds.

	Josh Carpenter [:jcarpenter]
	Comment 3 • 12 years ago

I think that's fine. The raison d'etre behind this bug ("When the alarm rings, pressing the volume rocker should dismiss the alarm.") is not must-have for v1.

	Gene Lian (I already quit Mozilla)
	Comment 4 • 12 years ago

(In reply to Alive Kuo [:alive] from comment #2)
> As Jonas said, we don't have a proper way to dismiss alarm from system app.
> System app doesn't know who is alarm app to dismiss or close when alarm
> sounds.

All right, but I think it's a bit beyond the scope of what the Alarm API was designed for so I think we don't really have a good title here.

	Jonas Sicking (:sicking) No longer reading bugmail consistently Reporter
	Comment 5 • 12 years ago

Indeed, the Alarm API isn't involved here. Once the alarm app is making sound the Alarm API is out of the picture and all we have is normal usage of ab <audio> element.

	Gene Lian (I already quit Mozilla)
	Comment 6 • 12 years ago

Let's change the title back. ;)

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 7 • 12 years ago

(In reply to Gene Lian [:gene] from comment #6)
> Let's change the title back. ;)

Gene, that title was coming from the original cloned bug.

	Andrea Marchesini [:baku]
	Comment 8 • 12 years ago

I think this bug is already fixed. The volume manager receives the audio-channel-changed event, and the right audio channel volume is correctly changed.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 9 • 12 years ago

(In reply to Andrea Marchesini (:baku) from comment #8)
> I think this bug is already fixed. The volume manager receives the
> audio-channel-changed event, and the right audio channel volume is correctly
> changed.

Nope. The mozChromeEvent is fired to system app, which doesn't know how to close the alarm.
This should remain opened until we have a better solution on delegating hardware button events.

	Marcus Cavanaugh [:mcav] Assignee
	Comment 11 • 10 years ago

This is addressed in bug 996092. Pressing the volume rocker dismisses the alarm.

We're still waiting on direct hardware button access, so we had to work around the platform a bit by hackishly listening to audio volume change events, but for now it works well.