Closed
Bug 812742
Opened 12 years ago
Closed 12 years ago
Sequence codegen is a major footgun
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
It passes through "(*arr.AppendElement())" as the declName, so if the inner type conversion template uses ${declName} twice bad things happen. Luckily nothing does that, as far as I can tell... until bug 767933.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #682719 -
Flags: review?(peterv)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 682719 [details] [diff] [review]
Fix sequence codegen to not do AppendElement multiple times by accident.
Review of attachment 682719 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/Codegen.py
@@ +2221,5 @@
> {
> "val" : "temp",
> "valPtr": "&temp",
> + "declName" : "slot",
> + "holderName": "tempHolder",
This tempHolder shouldn't be used, right? Can we keep not passing a holderName? If not, we should at least add a comment about that.
Attachment #682719 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c3d44fd7dce4 with a comment added explaining the holderName bit.
Bug 767933 will make us fail tests without this patch, so in-testsuite+.
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla20
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•