Closed
Bug 812782
Opened 12 years ago
Closed 12 years ago
Rename find_wrapped_to_bottom to reflect string change
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 19
Tracking | Status | |
---|---|---|
firefox19 | --- | fixed |
People
(Reporter: flod, Assigned: RyanVM)
References
Details
(Whiteboard: [pdfjs-c-integration])
Attachments
(1 file)
(deleted),
patch
|
bdahl
:
review+
flod
:
feedback+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 803644 fixed a wrong string in PDF Viewer: the string was changed but the identifier wasn't.
Please rename the key find_wrapped_to_bottom to make it visible to all localizers.
Assignee | ||
Comment 1•12 years ago
|
||
Brendan/Yury, I can make a patch for this to land with the 0.6.141 update if you let me know how you want to proceed with this.
Updated•12 years ago
|
Priority: -- → P1
Whiteboard: [pdfjs-c-integration]
Assignee | ||
Comment 2•12 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 810107
User impact if declined: localizers won't know that a string was updated
Testing completed (on m-c, etc.): trivial, just renaming some keys
Risk to taking this patch (and alternatives if risky): minor
String or UUID changes made by this patch: changes to key names
Assignee: nobody → ryanvm
Attachment #683756 -
Flags: review?(bdahl)
Attachment #683756 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 683756 [details] [diff] [review]
Update pdf.js to version 0.6.143
Francesco, does this look OK to you?
Attachment #683756 -
Flags: feedback?(francesco.lodolo)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 683756 [details] [diff] [review]
Update pdf.js to version 0.6.143
Yep, looks ok to me.
Attachment #683756 -
Flags: feedback?(francesco.lodolo) → feedback+
Comment 5•12 years ago
|
||
Brian - please review asap so that localizers get this change very early in the aurora cycle.
Updated•12 years ago
|
Attachment #683756 -
Flags: review?(bdahl) → review+
Comment 7•12 years ago
|
||
Comment on attachment 683756 [details] [diff] [review]
Update pdf.js to version 0.6.143
We only enabled Aurora updates yesterday - so this just missed string freeze. I doubt this will be a sticking point for localizers given how early we are in the cycle. Please land asap.
Attachment #683756 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c78f2ee337b0
(This will get merged to m-c with the next pdf.js upstream update coming in a day or two)
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox19:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•