Closed Bug 812782 Opened 12 years ago Closed 12 years ago

Rename find_wrapped_to_bottom to reflect string change

Categories

(Firefox :: PDF Viewer, defect, P1)

x86_64
Windows 7
defect

Tracking

()

RESOLVED FIXED
Firefox 19
Tracking Status
firefox19 --- fixed

People

(Reporter: flod, Assigned: RyanVM)

References

Details

(Whiteboard: [pdfjs-c-integration])

Attachments

(1 file)

Bug 803644 fixed a wrong string in PDF Viewer: the string was changed but the identifier wasn't. Please rename the key find_wrapped_to_bottom to make it visible to all localizers.
Brendan/Yury, I can make a patch for this to land with the 0.6.141 update if you let me know how you want to proceed with this.
Priority: -- → P1
Whiteboard: [pdfjs-c-integration]
[Approval Request Comment] Bug caused by (feature/regressing bug #): bug 810107 User impact if declined: localizers won't know that a string was updated Testing completed (on m-c, etc.): trivial, just renaming some keys Risk to taking this patch (and alternatives if risky): minor String or UUID changes made by this patch: changes to key names
Assignee: nobody → ryanvm
Attachment #683756 - Flags: review?(bdahl)
Attachment #683756 - Flags: approval-mozilla-aurora?
Comment on attachment 683756 [details] [diff] [review] Update pdf.js to version 0.6.143 Francesco, does this look OK to you?
Attachment #683756 - Flags: feedback?(francesco.lodolo)
Comment on attachment 683756 [details] [diff] [review] Update pdf.js to version 0.6.143 Yep, looks ok to me.
Attachment #683756 - Flags: feedback?(francesco.lodolo) → feedback+
Brian - please review asap so that localizers get this change very early in the aurora cycle.
Attachment #683756 - Flags: review?(bdahl) → review+
(meant to say Brendan in comment 5)
Comment on attachment 683756 [details] [diff] [review] Update pdf.js to version 0.6.143 We only enabled Aurora updates yesterday - so this just missed string freeze. I doubt this will be a sticking point for localizers given how early we are in the cycle. Please land asap.
Attachment #683756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/c78f2ee337b0 (This will get merged to m-c with the next pdf.js upstream update coming in a day or two)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: