Closed
Bug 813209
Opened 12 years ago
Closed 12 years ago
Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaResource on top of MediaResource
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
I need this refactoring in order to make it possible to implement BufferMediaResource which represents a media resource sitting in a memory buffer.
Attachment #683194 -
Flags: review?(cpearce)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 683194 [details] [diff] [review]
Patch (v1)
Review of attachment 683194 [details] [diff] [review]:
-----------------------------------------------------------------
s/CommonMediaResource/BaseMediaResource/
Attachment #683194 -
Flags: review?(cpearce) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: nobody → ehsan
|
|
Assignee | |
Comment 3•12 years ago
|
||
Backed out because of leaks: https://hg.mozilla.org/integration/mozilla-inbound/rev/da5c7437f563
I suspect the leaks might be happening because I'm counting the wrong ctor/dtor...
|
|
Assignee | |
Comment 4•12 years ago
|
||
Yep, this fixes the leaks.
Attachment #683194 -
Attachment is obsolete: true
Attachment #683336 -
Flags: review?(cpearce)
|
|
||
Updated•12 years ago
|
Attachment #683336 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
What's BufferMediaSource/MediaSource in the bug summary? Did you mean BufferMediaResource/MediaResource?
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
|
Assignee | |
Comment 8•12 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> What's BufferMediaSource/MediaSource in the bug summary? Did you mean
> BufferMediaResource/MediaResource?
Yes, sorry for the mistake. The idea is that BufferMediaResource will be an implementation of MediaResource based on top of an in-memory buffer.
Summary: Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaSource on top of MediaSource → Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaResource on top of MediaResource
You need to log in
before you can comment on or make changes to this bug.
Description
•