Closed
Bug 813470
Opened 12 years ago
Closed 12 years ago
Add a test page to litmus-data repository to test preferred language
Categories
(Mozilla QA Graveyard :: Infrastructure, defect)
Mozilla QA Graveyard
Infrastructure
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: AndreeaMatei, Assigned: AlexLakatos)
References
Details
(Whiteboard: [litmus-data])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
This is needed for bug 812435 where testPreferredLanguage.js at this moment uses Google page, which causes failures whenever the page gets changed.
It would have to read the HTTP header for the accepted language.
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → andreea.matei
Reporter | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Added a php file that checks the HTTP headers and generates the page
Attachment #688894 -
Flags: review?(hskupin)
Attachment #688894 -
Flags: review?(dave.hunt)
Attachment #688894 -
Flags: review?(andreea.matei)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 688894 [details] [diff] [review]
patch v1.0
Tested this on en-US and italian build as well, works as expected, just two things:
>+ "pt" => array(
This would need to be "pl" from Polish.
>+ <div>
This div is not closed later.
Thanks.
Attachment #688894 -
Flags: review?(hskupin)
Attachment #688894 -
Flags: review?(dave.hunt)
Attachment #688894 -
Flags: review?(andreea.matei)
Attachment #688894 -
Flags: review-
Comment 3•12 years ago
|
||
Comment on attachment 688894 [details] [diff] [review]
patch v1.0
Review of attachment 688894 [details] [diff] [review]:
-----------------------------------------------------------------
This is way too much code. The only content this patch has to display is the value of $_SERVER["HTTP_ACCEPT_LANGUAGE"].
Attachment #688894 -
Flags: review-
Comment 4•12 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3)
> This is way too much code. The only content this patch has to display is the
> value of $_SERVER["HTTP_ACCEPT_LANGUAGE"].
s/patch/page
Assignee | ||
Comment 5•12 years ago
|
||
simplified patch, just echoing the language
Assignee: andreea.matei → alex.lakatos
Attachment #688894 -
Attachment is obsolete: true
Attachment #689745 -
Flags: review?(hskupin)
Attachment #689745 -
Flags: review?(dave.hunt)
Attachment #689745 -
Flags: review?(andreea.matei)
Comment 6•12 years ago
|
||
Comment on attachment 689745 [details] [diff] [review]
patch v2.0
Review of attachment 689745 [details] [diff] [review]:
-----------------------------------------------------------------
Oh my. Something I have mentioned a couple of times in the past hit us now. We really haven't checked for existing unit tests or mochitests which probably would exercise this path. So I did a quick check and found:
http://mxr.mozilla.org/mozilla-central/source/netwerk/test/unit/test_header_Accept-Language.js
That means testing the HTTP header is already done and we do not have to do it again! Instead our test simply has to check if we correctly set the appropriate preference via the preferences UI. There is no real need to have an even external testcase hosted.
We should get better on it checking existing tests before re-inventing the wheel.
Attachment #689745 -
Flags: review?(hskupin)
Attachment #689745 -
Flags: review?(dave.hunt)
Attachment #689745 -
Flags: review?(andreea.matei)
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•