Seen starting https://hg.mozilla.org/comm-central/rev/6996e05c74ee but that hardly caused it. Some core change perhaps? SUMMARY-UNEXPECTED-FAIL | c:\talos-slave\test\build\mozmill\message-header\test-phishing-bar.js | test-phishing-bar.js::test_phishing_bar_for_eml_attachment EXCEPTION: Notification bar is collapsed! at: test-folder-display-helpers.js line 2831 assert_true test-folder-display-helpers.js 2831 assert_phishing_bar_visible test-phishing-bar.js 42 test_phishing_bar_for_eml_attachment test-phishing-bar.js 89 Runner.prototype.wrapper frame.js 582 Runner.prototype._runTestModule frame.js 652 Runner.prototype.runTestModule frame.js 698 Runner.prototype.runTestDirectory frame.js 522 runTestDirectory frame.js 704 Bridge.prototype._execFunction server.js 179 Bridge.prototype.execFunction server.js 183

I'm bisecting this one today.

Bisecting this has revealed it to be fallout from bug 811193.

So, if I'm reading this correctly - this didn't just break a test; this has actually busted our ability to detect phishing emails. Nice. Looks like just an interface change, anyhow.

I'm not entirely sure what needs to happen here to fix our phishing detection. Clearly, because of https://bugzilla.mozilla.org/attachment.cgi?id=681049&action=diff , we need to change what we're passing to safeLookup. Any idea what we're supposed to do to change the key from an ACString to an nsIPrincipal?

Bug 775796 may provide some hints

This fixes the test for me, and causes the phishing toolbar to appear. Try builds coming here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=1ec926fe3faa

Comment on attachment 684284 [details] [diff] [review] Patch v1 Review of attachment 684284 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/phishing/list-warden.js @@ +164,5 @@ > this.debugZone = "multitablequerier"; > + > + let uri = Services.io.newURI(url, null, null); > + this.principal_ = Components.classes["@mozilla.org/scriptsecuritymanager;1"] > + .getService(Components.interfaces Services.scriptSecurityManager

Comment on attachment 684284 [details] [diff] [review] Patch v1 Review of attachment 684284 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me

(In reply to Magnus Melin from comment #7) > Comment on attachment 684284 [details] [diff] [review] > Patch v1 > > Review of attachment 684284 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/components/phishing/list-warden.js > @@ +164,5 @@ > > this.debugZone = "multitablequerier"; > > + > > + let uri = Services.io.newURI(url, null, null); > > + this.principal_ = Components.classes["@mozilla.org/scriptsecuritymanager;1"] > > + .getService(Components.interfaces > > Services.scriptSecurityManager Ah, way better. Wasn't aware that the script security manager was in there. Thanks Magnus!

Fixed patch

Comment on attachment 684413 [details] [diff] [review] Patch v2 (r+'d by Standard8) Looks like bug 811193 got landed on mozilla-aurora, so that's busted us there.