Closed
Bug 814104
Opened 12 years ago
Closed 12 years ago
Create the loadSubScript function in the right compartment
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox18 fixed, firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
Firefox 20
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
The loadSubScript function in dbg-server.jsm is imported into a sandbox and then executed to load subscripts. Importing functions totally confuses our compartment sharing stuff we have for b2g, so those subscripts are ending up being run in the JSM scope instead of in the sandbox. The attached patch creates the function in the sandbox so it's associated with the right scope and good things happen.
robcee, please redirect the review if you can't review this.
Attachment #684116 -
Flags: review?(rcampbell)
|
||
Updated•12 years ago
|
Attachment #684116 -
Flags: review?(rcampbell) → review+
|
||
Comment 1•12 years ago
|
||
Can you use function.toSource() instead?
|
||
Comment 2•12 years ago
|
||
function.toSource() is our extension. Standard function.toString() would be preferred.
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
|
||
Comment 4•12 years ago
|
||
Please post changeset links and set the appropriate status flags when uplifting.
https://hg.mozilla.org/releases/mozilla-aurora/rev/444a70f88360
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
|
Assignee | |
Comment 5•12 years ago
|
||
status-firefox18:
--- → fixed
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•