Currently on recent trunk mozilla-central builds, when one closes a tab; what I believe to be it's border or shadow outlining (a thin 1px?) border is visible and animates upwards. It just looks out of place. This is very present against the tab menu background when one closes the last remaining tab.

Screenshot of it caught in action as it rises to the top

(In reply to Aaron Train [:aaronmt] from comment #0) > Currently on recent trunk mozilla-central builds Also visible on current Aurora builds.

Right. This is the listview divider moving up because we shrink the row by animating on height. It might be the case to not use divider and simply and a 1dp gap between elements with a darker background underneath. I can look into that.

The new design (in progress) for tabs-tray doesn't have a divider. Please check with ibarlow on that.

It actually will have a divider after all. Sorry Sriram, removing the tab tray title bar just doesn't scale as well as I had hoped it would.

The regression window for this issue is: good build: 2012/10/13 bad build 2012/10/14 possible push-log: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90857937b601&tochange=57304bbf9c0e

Still reproducible on mozilla-central/mozilla-aurora (12/17).

Sriram - Since the tabs tray re-work is happening now, can we fix this now?

I don't understand the actual UI here. Do we need dividers in tabs-tray? If not, I can remove the divider. That will remove this 1px. But, we have a 2dp divider on pre-honeycomb phones. I don't know why there is a regression in that. Also, why is the row sliding, and then shifting up? This was part of the animation logic. As lucas implemented it, I am not sure why he took that approach. To suppress the problem, I can remove the dividers, if that's fine.

Sounds like some info is needed from Lucas

The animation to slide the remaining tabs up involve shrinking the removed tab. This means the divider for the removed tab (which is part of the listview, not the tab row itself) will be visible until it actually gets removed. My impression is that, design-wise, we do want to keep the divider. One solution could to move the divider view to the row view itself. This way we'd have more control over its visibility while animating the tabs.

The new tab tray design removes dividers between thumbnail rows. So is this still relevant? https://bug817675.bugzilla.mozilla.org/attachment.cgi?id=697580

(In reply to Ian Barlow (:ibarlow) from comment #13) > The new tab tray design removes dividers between thumbnail rows. So is this > still relevant? > > https://bug817675.bugzilla.mozilla.org/attachment.cgi?id=697580 Not relevant anymore then. Thanks for pointing this out.