Ben Turner (not reading bugmail, use the needinfo flag!) Reporter
	Description • 12 years ago

Notes from conversation with gregor:

settings:
  settings-read and settings-write both checked in child for dom access, but returns non-null if access not granted (logs error to console only)
  doesn't assert permission before adding listeners ("Settings:RegisterForMessages")

We should tighten this up a little.

	Andrew Overholt [:overholt]
	Comment 1 • 12 years ago

Gregor, Doug said you should be the lucky owner of this bug.  Congrats!  :)

	Gregor Wagner [:gwagner] Assignee
	Comment 3 • 12 years ago

(In reply to ben turner [:bent] from comment #0)
> Notes from conversation with gregor:
> 
> settings:
>   settings-read and settings-write both checked in child for dom access, but
> returns non-null if access not granted (logs error to console only)

fixed by 815398

>   doesn't assert permission before adding listeners
> ("Settings:RegisterForMessages")

This patch

	Gregor Wagner [:gwagner] Assignee
	Comment 4 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a242c45cc80b

	Ed Morley [:emorley]
	Comment 5 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/a242c45cc80b

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/5796235869f1
https://hg.mozilla.org/releases/mozilla-beta/rev/b1958d544900