Closed
Bug 814294
Opened 12 years ago
Closed 12 years ago
Don't prompt for missing permissions (UNKNOWN_ACTION)
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: pauljt, Assigned: gwagner)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
DeviceStorage should only be able to be requested by Privileged & Certified Apps. (as per https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Akyz_Bqjgf5pdENVekxYRjBTX0dCXzItMnRyUU1RQ0E#gid=0)
Currently on Firefox OS (both desktop and device), even web content can request the permission by accessing the API. See http://dogs.creativemisuse.com/ and try clicking the"add an image" or "read music dir" buttons.
Note that this issue doesn't seem to be present on Firefox desktop, even when the device.storage.enabled pref is true. (tested in mac 18.0a2)
This will be security issue once privileged apps has landed, so should be blocking basecamp I think.
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #685314 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•12 years ago
|
Summary: DeviceStorage should be restricted to Privileged Apps → Don't prompt for missing permissions (UNKNOWN_ACTION)
|
|
Assignee | |
Comment 2•12 years ago
|
||
We shouldn't treat missing permissions as prompt permissions.
I think I get the right behavior now for http://dogs.creativemisuse.com/
Paul, can you test as well?
Attachment #685314 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Comment 5•12 years ago
|
||
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•