Closed
Bug 814331
Opened 12 years ago
Closed 12 years ago
Use info/collection_counts to avoid hitting bookmark limits
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
We should fetch collection_counts on a first sync.
http://docs.services.mozilla.com/storage/apis-2.0.html#general-info
If we're going to bump into any limits, refuse to sync that engine, and pop up a (localized, of course) notification explaining that, e.g., you've got too many bookmarks for Firefox to sync to this device.
Track that a notification has been recorded, so we don't do it again. Keep checking the count each time we do a full sync. If it drops below the limit, sync that engine.
On a fresh-server first sync… well, that needs a little thought. Can't be worse than now.
This is a decent holdover until we implement full-scale incremental sync.
Assignee | ||
Comment 1•12 years ago
|
||
https://github.com/mozilla-services/android-sync/pull/273
Does not yet show a notification, not yet tested on device.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
This bug is a good idea. One minor nit:
(In reply to Richard Newman [:rnewman] from comment #0)
> e.g., you've got too many bookmarks for Firefox to sync to this device.
Perhaps the words "this device" should not be included in the notification. Firefox Sync destroys my Bookmarks' folder structure on *every* device I have, incl. my PC and my Netbook (both Windows 7 with 2+ GB RAM). It's not the devices' fault; its a deficiency in Firefox Sync. We shouldn't deflect and misrepresent the blame in the error message.
Comment 3•12 years ago
|
||
I just realized that my Netbook sync problem could be related to the Android Sync of my phone & tablet, so now I'm not sure anymore if it's Firefox Sync or just Android Sync that caused my Nettboook's bookmark folders to go KABOOM. Can I turn on Firefox Sync again on just my PC and Netbook? I have about 3,500 bookmarks.
Comment 4•12 years ago
|
||
(In reply to Peter Lairo from comment #3)
> I just realized that my Netbook sync problem could be related to the Android
> Sync of my phone & tablet, so now I'm not sure anymore if it's Firefox Sync
> or just Android Sync that caused my Nettboook's bookmark folders to go
> KABOOM. Can I turn on Firefox Sync again on just my PC and Netbook? I have
> about 3,500 bookmarks.
You should be able to disable Sync on all of your Android devices and have all of your desktop devices (PC and Netbook) still use Sync.
This configuration should not have any problems with bookmarks.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Peter Lairo from comment #2)
> Perhaps the words "this device" should not be included in the notification.
> Firefox Sync destroys my Bookmarks' folder structure on *every* device I
> have, incl. my PC and my Netbook (both Windows 7 with 2+ GB RAM). It's not
> the devices' fault; its a deficiency in Firefox Sync.
That's not broadly true. There is probably damaged persistent state in your Sync account.
If you can reproduce bookmark structure problems on a *new* (or wiped) Sync account, using only desktop clients, please file a new bug in Mozilla Services > Firefox Sync: Backend.
Comment 6•12 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #5)
> If you can reproduce bookmark structure problems on a *new* (or wiped) Sync
> account, ...
Would it be sufficient to select "Replace all other devices with this device's data"? (under Options / Sync / Manage Account / Reset Sync)
BTW: It's pretty hard (or unintuitive how) to select that option without having Sync already having started syncing beforehand, which kind of defeats the purpose of avoiding getting an unwanted or broken bookmarks database onto another device.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Peter Lairo from comment #6)
> Would it be sufficient to select "Replace all other devices with this
> device's data"? (under Options / Sync / Manage Account / Reset Sync)
Yup. That'll wipe storage for known engines, reupload, and tell other clients that they need to wipe-and-apply.
A more thorough test is to set up a new sync account with a new profile…
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/386f67f3f987
This is the first part: we simply refuse to sync a collection if there are too many items. When we get a chance, we'll either add a notification or build a better implementation.
Target Milestone: --- → mozilla20
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: Mozilla Services → Android Background Services
Comment 10•9 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #8)
> When we get a chance, we'll either add a notification or
> build a better implementation.
There is no indication that initial sync of my 7628 bookmarks kept failing in Firefox for Android, so I filed bug 1239105. I think "a better implementation" is bug 814801
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•