Closed Bug 81473 Opened 24 years ago Closed 22 years ago

The accesskey attribute does not work for the area element

Categories

(Core :: Layout, defect, P2)

x86
All
defect

Tracking

()

RESOLVED FIXED
mozilla1.1alpha

People

(Reporter: bsharma, Assigned: yinbolian)

References

()

Details

(Keywords: access, testcase, Whiteboard: [bae:20011127])

Attachments

(1 file, 3 obsolete files)

The accesskey attribute does not work for the area element although the area is 
accessible through mouse and it works fine.
*** Bug 84357 has been marked as a duplicate of this bug. ***
HTML Element component is deprecated, and should be removed from Bugzilla.
Clayton is not the correct owner for these. Reassigning to layout.
Assignee: clayton → karnaze
Component: HTML Element → Layout
QA Contact: bsharma → petersen
Keywords: access
Build 2001-07-27-branch on WinNT and Linux.

Same is the problem with the test case of no DOCTYPE.
Tested with build ID 2001-09-21-05-0.9.4 on windows 2000 SP1, same problem, 
Changing OS to ALL
OS: Windows NT → All
confirmed in today's build, but also not a table specific problem, reassigning 
to core owner.
Assignee: karnaze → attinasi
Bumping this one up since it affects accessibility. Confirmed using the win98 
build from 20011127.
Keywords: testcase
Priority: -- → P2
Whiteboard: [bae:20011127]
Target Milestone: --- → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.1
*** Bug 49968 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1
Marking nsbeta1-. Engineers are overloaded with higher priority bugs, so there
is not much chance we will be able to get to this.
Keywords: nsbeta1nsbeta1-
*** Bug 145394 has been marked as a duplicate of this bug. ***
=> bolian.
I am trying to fix it.
Assignee: attinasi → bolian.yin
Status: NEW → ASSIGNED
Attached patch set accesskey attribute of area (obsolete) (deleted) — Splinter Review
seek r=?
Comment on attachment 90458 [details] [diff] [review]
set accesskey attribute of area

I'd think you'd need to change SetDocument as well, don't you?	I'm surprised
this works, except for the case of dynamic attribute changes.  See the code in
nsHTMLAnchorElement.cpp.
Attached patch patch_v2 (add SetDocument method) (obsolete) (deleted) — Splinter Review
Attachment #90458 - Attachment is obsolete: true
Comment on attachment 90597 [details] [diff] [review]
patch_v2 (add SetDocument method)

r=dbaron.  You should probably get jst to sr, though.
Attachment #90597 - Flags: review+
Attachment #90597 - Flags: superreview+
Comment on attachment 90597 [details] [diff] [review]
patch_v2 (add SetDocument method)

+  if (aName == nsHTMLAtoms::accesskey && kNameSpaceID_None == aNameSpaceID) {

Please change the latter equality check to do variable == constant in stead of
the other way around (i.e. aNameSpaceID == kNameSpaceID_None in stead of
kNameSpaceID_None == aNameSpaceID).

sr=jst
Attached patch patch (for checkin, add jst's comment) (obsolete) (deleted) — Splinter Review
Attachment #90597 - Attachment is obsolete: true
Comment on attachment 90885 [details] [diff] [review]
patch (for checkin, add jst's comment)

a=asa (on behalf of drivers) for checkin to 1.1
Attachment #90885 - Flags: superreview+
Attachment #90885 - Flags: review+
Attachment #90885 - Flags: approval+
Attached patch updated against trunk July23 (deleted) — Splinter Review
Attachment #90885 - Attachment is obsolete: true
checked into trunk!
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
we would like to see this fix checked in branch too, removing nsbeta1- and
adding nsbeta1
Keywords: nsbeta1-nsbeta1
We moved the test cases to different location. I updated the above url to
reflect the current test case.
I was verifying this bug in branch build 20030212 and found its not checked into
the branch yet. Can anybody verify if its checked into branch.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: