Closed Bug 814890 Opened 12 years ago Closed 12 years ago

[toolbox] Markup panel is sometimes blank on page change

Categories

(DevTools :: Inspector, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: vporof, Assigned: miker)

References

Details

Attachments

(1 file, 1 obsolete file)

STR: 1. Go to http://htmlpad.org/debugger/ 2. Open inspector 3. Go to http://students.info.uaic.ro/~victor.porof The markup panel is empty. Inspecting via the breadcrumbs or the highlighter works properly.
Component: Developer Tools: Debugger → Developer Tools: Inspector
Blocks: 788977
Blocks: 816946
It also happens when you change something on bugzilla (add a comment for example).
No longer blocks: 788977
Priority: -- → P1
I can no longer reproduce this on fx-team ... Victor, is it also working for you?
Flags: needinfo?(vporof)
Whiteboard: [needinfo]
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2) > I can no longer reproduce this on fx-team ... Victor, is it also working for > you? Still happens to me. Try navigating back and forth a few times.
Flags: needinfo?(vporof)
Another STR: - go to http://paulrouget.com/e/toolboxTesting/ - start the inspector (lock a node) - click on the image - blank markup view
Whiteboard: [needinfo]
Assignee: nobody → mratcliffe
Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Sometimes the DOMContentLoaded event has already been fired when we add the listener. We now use either DOMContentLoaded or load, whichever is triggered first. This fixes Paul's image issue but I am still unable to replicate Victor's, probably due to differences in our setup. Victor, does this patch fix the issue for you?
Attachment #693830 - Flags: review?(paul)
Attachment #693830 - Flags: feedback?(vporof)
Whiteboard: [has-patch][needinfo]
Whiteboard: [has-patch][needinfo] → [needs-review][needinfo]
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #6) > Created attachment 693830 [details] [diff] [review] > Patch v1 Still not fixed :( STR: 1. Go to http://htmlpad.org/debugger/ 2. Open Inspector and lock the highlighter on the button node 3. Switch address to http://students.info.uaic.ro/~victor.porof 4. Go back. Everything ok so far. 5. Go forward. Cake or death. I'm now getting this exception when the bug is triggered: [Exception... "A parameter or an operation is not supported by the underlying object" code: "15" nsresult: "0x8053000f (InvalidAccessError)" location: "resource:///modules/devtools/CssLogic.jsm Line: 1105"]: undefined
Comment on attachment 693830 [details] [diff] [review] Patch v1 + // Sometimes, e.g. when viewing images, the DOMContentLoaded event + // will have already fired so the listener added here will not always be + // called. We fall back to the load listener to cover us in these + // situations. No. Check the readyState==interactive before attaching a callback: https://developer.mozilla.org/en-US/docs/DOM/document.readyState
Attachment #693830 - Flags: review?(paul) → review-
I meant: if (readyState == "interactive") { onDOMReady(); } else { addEventListener("DOMContentLoaded", onDOMReady); }
Attached patch Patch v2 (deleted) — Splinter Review
(In reply to Paul Rouget [:paul] from comment #9) > I meant: > > if (readyState == "interactive") { > onDOMReady(); > } else { > addEventListener("DOMContentLoaded", onDOMReady); > } The flow is: loading interactive DOMContentLoaded complete load We receive the DOMContentLoaded event very early in the interactive phase (which begins when the DOM Tree has been built). If we use "interactive" we could miss the event. I attach the listener if the document is loading, otherwise we are safe to call onDOMReady(). It seems to be completely solid now.
Attachment #693830 - Attachment is obsolete: true
Attachment #693830 - Flags: feedback?(vporof)
Attachment #694371 - Flags: review?(paul)
Whiteboard: [needs-review][needinfo] → [needs-review]
Attachment #694371 - Flags: review?(paul) → review+
Whiteboard: [needs-review] → [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
cc-ing blake. I think you were describing this to me last night. Should be fixed on next merge to central.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: