Closed
Bug 815011
Opened 12 years ago
Closed 12 years ago
Appdir preferences are not being loaded for xpcshell tests on elm
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 810617
People
(Reporter: bbondy, Assigned: bbondy)
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review-
|
Details | Diff | Splinter Review |
Appdir preferences were not being loaded on elm causing app update xpcshell test errors.
I pushed an intermediate fix here, but I'm using this bug to see if we need a better fix. The fix I did can be found here:
https://hg.mozilla.org/projects/elm/rev/80b11b866a11
Assignee | ||
Comment 1•12 years ago
|
||
also in this followup changeset:
https://hg.mozilla.org/projects/elm/rev/da46872303a6
Assignee | ||
Comment 2•12 years ago
|
||
Assignee: nobody → netzen
Attachment #685010 -
Flags: review?(mh+mozilla)
Comment 3•12 years ago
|
||
Comment on attachment 685010 [details] [diff] [review]
Patch v1
Bug 810617 is set to fix this in a much better way.
Attachment #685010 -
Flags: review?(mh+mozilla) → review-
Comment 4•12 years ago
|
||
Yeah sorry I should have chatted with you about this in more details. I already went through a bunch of fixes in bug 810617, we settled on the (product)-appdir ini file fix. I'm looking at the remaining failures now.
Comment 5•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Created attachment 685010 [details] [diff] [review]
> Patch v1
I'm doing a mc merge now. Will back this out with it so we can look at all the remaining app dir test failures.
Assignee | ||
Comment 6•12 years ago
|
||
ok thanks, by the way the changeset contains more than just this so only undo these changes please Jim.
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Comment 8•12 years ago
|
||
Actually we could have kept this one, I've filed bug 810617 on the xpcshell dir provider issue.
Comment 9•12 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #8)
> Actually we could have kept this one, I've filed bug 810617 on the xpcshell
> dir provider issue.
* bug 815256
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 685010 [details] [diff] [review]
> Patch v1
>
> Bug 810617 is set to fix this in a much better way.
Ah OK I was just going based on this comment. You can re-open if you want to take the bug.
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•