Closed
Bug 815339
Opened 12 years ago
Closed 12 years ago
[OS.File] Extract PromiseWorker from OS.File
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Not sure yet how to approach bug 801598, but we can already extract the part of OS.File that wraps communication with a worker in promises, and this will be useful for bug 753768.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → dteller
Attachment #685324 -
Flags: review?(nfroyd)
Comment 2•12 years ago
|
||
Comment on attachment 685324 [details] [diff] [review]
Extracting PromiseWorker from OS.File
Review of attachment 685324 [details] [diff] [review]:
-----------------------------------------------------------------
Even if we wind up doing something different, I think this is much cleaner.
Attachment #685324 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #685324 -
Attachment is obsolete: true
Attachment #692274 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 8•12 years ago
|
||
Unfortunately, this has bitrotted more than I'm comfortable fixing up myself. Please post a rebased patch.
Keywords: checkin-needed
Assignee | ||
Comment 9•12 years ago
|
||
Assignee | ||
Comment 10•12 years ago
|
||
Same one, minus bitrot.
Attachment #692274 -
Attachment is obsolete: true
Attachment #693792 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 11•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 13•9 years ago
|
||
Hey all -- doing some doc updating here. I see there's some documentation already created, and I'm updating and tidying that up, and I notice that it's importing PromiseWorker.js instead of PromiseWorker.jsm. Which are you supposed to use, or are both used but in different circumstances, or...?
Assignee | ||
Comment 14•9 years ago
|
||
PromiseWorker.js needs to be imported from the worker, while PromiseWorker.jsm needs to be imported from the main thread.
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•