Closed Bug 815363 Opened 12 years ago Closed 12 years ago

PB changes broke autocomplete-will-enter-text notification

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: jdm, Assigned: jdm)

References

Details

Attachments

(1 file)

Make the autocomplete inPrivateContext getter call a real method.
(deleted), patch
mak
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Sigh. I noticed a bunch of NS_ENSURE_SUCCESS failures coming out of the nsNavHistory observer.
Blocks: 723005
Comment on attachment 685328 [details] [diff] [review] Make the autocomplete inPrivateContext getter call a real method. Review of attachment 685328 [details] [diff] [review]: ----------------------------------------------------------------- ugh! backport backport!
Attachment #685328 - Flags: review?(mak77) → review+
Assignee: nobody → josh
Comment on attachment 685328 [details] [diff] [review] Make the autocomplete inPrivateContext getter call a real method. [Approval Request Comment] Bug caused by (feature/regressing bug #): 723005 User impact if declined: Presumably some kind of awesomebar effectiveness decrease Testing completed (on m-c, etc.): Manual testing Risk to taking this patch (and alternatives if risky): Zero risk. String or UUID changes made by this patch: None.
Attachment #685328 - Flags: approval-mozilla-aurora?
Blocks: PBnGen
https://hg.mozilla.org/mozilla-central/rev/b21026bf9d44
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Attachment #685328 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: