Closed
Bug 815381
Opened 12 years ago
Closed 12 years ago
Root panel animates when settings app launches
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(blocking-basecamp:+)
RESOLVED
FIXED
blocking-basecamp | + |
People
(Reporter: Margaret, Assigned: arthurcc)
References
Details
(Whiteboard: [fast:0.7s])
Attachments
(3 files)
This looks kinda janky, so I think we should avoid animating the root panel when we launch the app.
Patch has been waiting on review.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•12 years ago
|
||
I found that when the settings app loads, document.location.hash == '#root', so we follow that path to show the panel. Since the HTML for the root panel is already loaded and showing, this isn't necessary.
I find that this patch makes the settings app feel a lot smoother when it launches.
Assignee: nobody → margaret.leibovic
Attachment #685347 -
Flags: review?(kaze)
Comment 3•12 years ago
|
||
Comment on attachment 685347 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6638
Sorry for the late review. Please let me finish working on my C2 bugs before reviewing this: I’m not sure this patch wouldn’t raise issues when the Settings app is launched on a different panel (web activities…).
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → DUPLICATE
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 7•12 years ago
|
||
As Chris just suggested, asking Evelyn to review this patch.
Evelyn, please make sure this patch doesn’t raise issues when the Settings app is started on a non-#root URL (= web activities). Thanks!
Updated•12 years ago
|
Attachment #685347 -
Flags: review?(kaze) → review?(ehung)
This is a *0.7s* startup win for settings.
700 milliseconds.
I'm going to do the honors here ;). P1 because this is the most important startup win we have, along with bug 780692.
Please let's get this reviewed and landed asap.
blocking-basecamp: ? → +
Priority: -- → P1
Updated•12 years ago
|
Blocks: Settings-Startup
Comment 10•12 years ago
|
||
I've tested it and it works for the only one web activity we have now. It's a window disposition activity for wifi setting, starting at root page and then moving to wifi panel when the activity handler is invoked. so it's fine with the patch.
I also made a inline disposition activity to test this patch, but it works not so good, the panel I specified for the inline activity will loading with a slip animation. My test case attached, you can test it by trigger an "Inline Activity Test" in UI Tests app.
Comment 11•12 years ago
|
||
Please note the old 'unlock' SIM PIN inline disposition activity which links to 'unlock_simpin.html' has been retired. That's why I say we only have a window disposition activity. So here, I'm testing a possible case of the future.
Comment 12•12 years ago
|
||
Comment on attachment 685347 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6638
After a long discussion, Arthur has another approach for this issue that seems fix the issue and won't case web activity side-effect. So I'd like to left someone else review both patches and make a decision. :)
Attachment #685347 -
Flags: review?(ehung)
Comment 13•12 years ago
|
||
Evelyn, do we have an ETA concerning Arthur’s patch?
Comment 14•12 years ago
|
||
ooops, forget my last comment.
/me needs more coffee
Assignee | ||
Comment 15•12 years ago
|
||
The idea of this patch is to apply the css animation after the target panel loaded and positioned. This solution also guarantees that the target panel not animated when the settings app is launched with a hash value.
Attachment #688683 -
Flags: review?(timdream+bugs)
Comment 16•12 years ago
|
||
Comment on attachment 688683 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6817
r=me. Please squash all commit into one and remove the trailing white space before merging, thanks.
Attachment #688683 -
Flags: review?(timdream+bugs) → review+
Assignee | ||
Comment 17•12 years ago
|
||
Fixed.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 18•12 years ago
|
||
Updated•12 years ago
|
Assignee: margaret.leibovic → arthur.chen
Comment 19•12 years ago
|
||
Just want to thank Margaret raised this issue and provided a patch which inspired Arthur so he can improve his approach. :)
Also thank kaze and Tim's help on reviewing patch.
Reporter | ||
Comment 20•12 years ago
|
||
This was a nice bugmail thread to wake up to :) Thanks everyone for helping fix the issue!
You need to log in
before you can comment on or make changes to this bug.
Description
•