Closed
Bug 815475
Opened 12 years ago
Closed 12 years ago
Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing
Categories
(Firefox :: PDF Viewer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: bbondy, Assigned: bbondy)
Details
(Whiteboard: [metro-it1][LOE:1][metro-mvp])
Attachments
(1 file)
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing. This is because the metro browser has no integrated find bar.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #685441 -
Flags: review?(dtownsend+bugmail)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [metro-it1][LOE:1][metro-mvp]
Comment 2•12 years ago
|
||
Brian, I think you'll want to patch the upstream pdf.js repo and submit a pull request there:
https://github.com/mozilla/pdf.js/blob/babd8df1769a82b1b65a9e394a68cf695ed179dd/extensions/firefox/components/PdfStreamConverter.js#L347
Comment 3•12 years ago
|
||
Pull request opened at https://github.com/mozilla/pdf.js/pull/2413
Assignee | ||
Comment 4•12 years ago
|
||
Was just about to do that, thanks saved me some time :)
Assignee | ||
Comment 5•12 years ago
|
||
Can we still push this to m-c or will we be doing another update to a newer version of pdfjs soon?
Comment 6•12 years ago
|
||
We need to update the version on m-c, yes. I'll file the bug for that once this is fixed upstream.
Assignee | ||
Comment 7•12 years ago
|
||
I think the pull request is already accepted to pdfjs
Updated•12 years ago
|
Attachment #685441 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Target Milestone: --- → Firefox 20
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•