Closed
Bug 815639
Opened 12 years ago
Closed 12 years ago
mLocalFile in nsDiskCacheStream doesn't have to be in the class
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: alfredkayser, Assigned: alfredkayser)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
michal
:
review+
michal
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 685640 [details] [diff] [review]
WIP: replace mLocalFile with localFile instead OpenCacheFile
As localFile is only used to open the file in OpenCacheFile, it is not needed to keep it around in the nsDiskCacheStreamIO object, saving bytes...
(see SizeOfIncludingThis where the size of LocalFile is reflected)
Attachment #685640 -
Attachment is patch: true
|
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: nobody → alfredkayser
Attachment #685640 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #692728 -
Flags: review?(michal.novotny)
|
||
Updated•12 years ago
|
Attachment #692728 -
Flags: review?(michal.novotny) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Is a superreview needed, or can this be submitted to the tree?
|
|
||
Comment 4•12 years ago
|
||
This change doesn't need sr.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #692728 -
Flags: checkin?(michal.novotny)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 692728 [details] [diff] [review]
V2: Rebased after bug 725993
https://hg.mozilla.org/integration/mozilla-inbound/rev/133dc155974b
Attachment #692728 -
Flags: checkin?(michal.novotny) → checkin+
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•