(I hope the wallet extension falls into this category; if not please let me know.) During some code inspections I did lately I came across many very inefficient uses of strlen (or PR_strlen or ...). They generally fall into two categories: - use of strlen() to test for empty strings; this could be done better by a constant-time test for zero of the first character - use of strlen() in a loop end test; this is inefficient since the test is repeated in every iteration; the compiler cannot see that the result will always be the same. I'll now append a patch which removes these problems in the files in extensions/wallet/src. I've tested it lightly.

Looks fine to me. Thanks for doing this. r=morse

sr=blizzard

a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)

Fix checked in.

Verified fix checked into lxr.mozilla.org