Closed Bug 816035 Opened 12 years ago Closed 12 years ago

Add times for individual tests to the XML report

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: davehunt, Assigned: mihneadb)

References

Details

Attachments

(1 file, 1 obsolete file)

As per bug 813779 comment 3. Having the individual test times will improve the reporting in Jenkins and highlight any test duration regressions, which may indicate performance issues.
Assignee: nobody → mihneadb
Attachment #689227 - Flags: review?(jgriffin)
Attachment #689227 - Flags: review?(dave.hunt)
Comment on attachment 689227 [details] [diff] [review] Save duration for every test and switch the testcase duration print to seconds Review of attachment 689227 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, except we want all the times in ms, rather than seconds, for Jenkins compatibility. Dave, correct me if I'm wrong.
Attachment #689227 - Flags: review?(jgriffin) → review-
(In reply to Jonathan Griffin (:jgriffin) from comment #2) > Comment on attachment 689227 [details] [diff] [review] > Save duration for every test and switch the testcase duration print to > seconds > > Review of attachment 689227 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, except we want all the times in ms, rather than seconds, for > Jenkins compatibility. Dave, correct me if I'm wrong. Haha, I was talking to :dave.hunt on IRC and he said we actually wanted seconds :). Make a decision and I'll change it, np.
Comment on attachment 689227 [details] [diff] [review] Save duration for every test and switch the testcase duration print to seconds Review of attachment 689227 [details] [diff] [review]: ----------------------------------------------------------------- I defer to Dave, seconds it is!
Attachment #689227 - Flags: review?(dave.hunt) → review+
:jgriffin, you changed Dave's review :)
Comment on attachment 689227 [details] [diff] [review] Save duration for every test and switch the testcase duration print to seconds Boy, I really need more coffee.
Attachment #689227 - Flags: review- → review?(dave.hunt)
Updating patch to include version bump.
Attachment #689227 - Attachment is obsolete: true
Attachment #689227 - Flags: review?(dave.hunt)
Attachment #690989 - Flags: review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Sorry for being late to review this - thanks Jonathan for picking it up. I've tested from mozilla-central and this works great!
This is failing on the Gaia Test UI with: Traceback (most recent call last): File "/var/jenkins/workspace/b2g.gaia.unagi/.env/bin/gaiatest", line 9, in <module> load_entry_point('gaiatest==0.4', 'console_scripts', 'gaiatest')() File "/var/jenkins/workspace/b2g.gaia.unagi/gaiatest/runtests.py", line 17, in main cli(runner_class=GaiaTestRunner) File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 702, in cli runner = startTestRunner(runner_class, options, tests) File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 697, in startTestRunner runner.run_tests(tests, testtype=options.type) File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 369, in run_tests f.write(self.generate_xml(self.results)) File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 528, in generate_xml _extract_xml(*tup, result='error') File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 493, in _extract_xml testcase.setAttribute('time', str(test.duration)) AttributeError: 'TestSettings' object has no attribute 'duration'
This is probably due to the lack of a default value.
I guess the test you were running was not extending MarionetteTestCase. Is that supposed to happen?
Whiteboard: [status-b2g18:fixed]
Whiteboard: [status-b2g18:fixed]
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: