Closed
Bug 816149
Opened 12 years ago
Closed 12 years ago
When updating hosted apps with appcache, the update is automatically done
Categories
(Core Graveyard :: DOM: Apps, defect, P1)
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)
People
(Reporter: julienw, Assigned: fabrice)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
ferjm
:
review+
|
Details | Diff | Splinter Review |
In Webapps.jsm, in updateHostedApp, we trigger automatically an update if the manifest changed.
However, we might want to ask the user first, as we do for packaged app, because we might download a lot of stuff.
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Updated•12 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Updated•12 years ago
|
Summary: [Webapps] When updating hosted apps with appcache, the update is automatically done → When updating hosted apps with appcache, the update is automatically done
Assignee | ||
Comment 2•12 years ago
|
||
Julien, can you build with this patch and check that it makes gaia happy?
Reporter | ||
Comment 3•12 years ago
|
||
I still couldn't try it yet but it seems something's missing, because you don't call |startOfflineCacheDownload| in the |startDownload| method.
Assignee | ||
Comment 4•12 years ago
|
||
Reporter | ||
Comment 5•12 years ago
|
||
oh yes, thanks, I missed that.
Will try this patch as soon as I can have a working out-of-b2g-tree gecko.
Comment 7•12 years ago
|
||
Setting priority based on triage discussions. Feel free to decrease priority if you disagree.
Priority: -- → P1
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #686601 -
Attachment is obsolete: true
Attachment #687424 -
Flags: review?(ferjmoreno)
Updated•12 years ago
|
Attachment #687424 -
Flags: review?(ferjmoreno) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 12•12 years ago
|
||
Reporter | ||
Comment 13•12 years ago
|
||
Sorry Fabrice, didn't have time to try the patch before landing.
I'm wondering if the "NOT_UPDATABLE" error will have an impact on the Gaia part.
Comment 14•12 years ago
|
||
Not working for me. See bug 824697 for a followup.
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•