Closed Bug 816598 Opened 12 years ago Closed 8 years ago

The Gecko Profiler needs a memory reporter

Categories

(Core :: Gecko Profiler, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: glandium, Assigned: n.nethercote)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Memshrink:P2])

Attachments

(1 file)

I have 1367 tabs open. I did the mistake to click on the tab groups button when i meant to hit the gecko profiler button (oops), and the result is that memory usage went from 1.3GB to 3GB, and about:memory now shows me this: ├──1,708.01 MB (49.49%) ── heap-unclassified
So I /think/ I identified it as being memory coming from SPS. We could definitely do with a memory reporter for SPS.
Component: Panorama → Gecko Profiler
Product: Firefox → Core
Summary: Huge heap-unclassified after opening tab groups page → SPS could use a memory reporter
Whiteboard: [Memshrink] → [Memshrink:P2]
Summary: SPS could use a memory reporter → SPS could use a memory reporter / Gecko profiler add-on allocates lots of heap-unclassified memory
Blocks: 1329219
I'm happy to take this one, though I won't get to it immediately.
Assignee: nobody → n.nethercote
Summary: SPS could use a memory reporter / Gecko profiler add-on allocates lots of heap-unclassified memory → The Gecko Profiler needs a memory reporter
mstange, please review the profiler parts. jseward, please review the LUL parts.
Attachment #8833852 - Flags: review?(mstange)
Attachment #8833852 - Flags: review?(jseward)
Comment on attachment 8833852 [details] [diff] [review] Add a memory reporter for the Gecko Profiler Looks OK to me. The potential unsafety that you refer to in the comments makes me vaguely nervous, but I don't think there's anything we can do about it.
Attachment #8833852 - Flags: review?(jseward) → review+
> Looks OK to me. The potential unsafety that you refer to in the > comments makes me vaguely nervous, but I don't think there's anything > we can do about it. We could convert the std::vector uses to nsTArray or mozilla::Vector. More work, obviously, and I took the lazy path for now...
Comment on attachment 8833852 [details] [diff] [review] Add a memory reporter for the Gecko Profiler Review of attachment 8833852 [details] [diff] [review]: ----------------------------------------------------------------- Seems fairly straightforward. Thanks!
Attachment #8833852 - Flags: review?(mstange) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: