Closed
Bug 816611
Opened 12 years ago
Closed 12 years ago
Intermediate widget test failures make tree orange
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: mossop)
References
Details
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•12 years ago
|
||
There seems to be bunch of intermediate time outs in widget tests, sometimes in tabs and windows code too. We need to figure out the cause and make fix it.
Priority: -- → P1
Erik, any chance you could try reproducing this?
|
||
Updated•12 years ago
|
Blocks: sdk/widget
|
Assignee | |
Comment 3•12 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 708376 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/752
This might be the cause, this timeout is frequently too short on Windows and so causes later tests to appear to fail too.
Attachment #708376 -
Flags: review?(kwierso)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → dtownsend+bugmail
Comment on attachment 708376 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/752
Ship it!
Attachment #708376 -
Flags: review?(kwierso) → review+
|
||
Comment 6•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/a2ddd4a16c254e820ab7da0e465104962ba722c1
Bug 816611: Remove the explicit timeout from the widget tests.
https://github.com/mozilla/addon-sdk/commit/3e8745342cfe2087ec71dff744bdbc0e13fcec51
Merge pull request #752 from Mossop/bug816611
Bug 816611: Remove the explicit timeout from the widget tests. r=Kwierso
|
|
Assignee | |
Comment 7•12 years ago
|
||
The tree looks a lot greener now so I'm going to call this fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•12 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/6fd5cae8451cb895be044222a853ef605f348004
Merge pull request #752 from Mossop/bug816611
Bug 816611: Remove the explicit timeout from the widget tests. r=Kwierso(cherry picked from commit 3e8745342cfe2087ec71dff744bdbc0e13fcec51)
You need to log in
before you can comment on or make changes to this bug.
Description
•