Closed
Bug 816903
Opened 12 years ago
Closed 12 years ago
Remove calls to addVisits from Places tests
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Paolo, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Notice the plural :-)
This is about removing the addVisits helper from head_common.js, once all the
calls to addVisit have been removed too.
|
||
Comment 1•12 years ago
|
||
This can be worked on, the idea is to remove addVisits() and use promiseAddVisits() everywhere, for coherence. Not a priority, just cleanup.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → raymond
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #708942 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed to try and looks ok.
https://tbpl.mozilla.org/?tree=Try&rev=cd98388262f6
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 708942 [details] [diff] [review]
v1
Review of attachment 708942 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #708942 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #708942 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•