Closed
Bug 816936
Opened 12 years ago
Closed 12 years ago
Need "New Private Window" in dock context menu for per-window private browsing.
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: tetsuharu, Assigned: ehsan.akhgari)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
Firefox needs "New Private Window" in dock context menu for per-window private browsing.
Assignee | ||
Comment 1•12 years ago
|
||
This sounds like a good idea, but we won't block shipping per-window private browsing on it. However it would be very nice to have, indeed!
Steven, can you please give me an idea on how these dock menu items should be added? Thanks!
Comment 2•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ehsan
Comment 3•12 years ago
|
||
> Steven, can you please give me an idea on how these dock menu items should
> be added?
I actually don't know much about manipulating the Dock, but a quick web search turned up the "Dock Tile Programming Guide" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/intro/dockintro.html), which has a section called "Dynamically Adding Menu Items With the Application Delegate" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/docktasks_cocoa/docktasks_cocoa.html#//apple_ref/doc/uid/TP30000986-CH3-SW1, scroll down to see it). We're already doing this at [MacApplicationDelegate applicationDockMenu:] in toolkit/xre/MacApplicationDelegate.mm.
And we already have an nsIMacDockSupport interface, implemented in widget/cocoa/nsMacDockSupport.mm.
> Thanks!
You're most welcome. Good luck!
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #688093 -
Flags: review?(josh)
Comment 5•12 years ago
|
||
Comment on attachment 688093 [details] [diff] [review]
Patch (v1)
Review of attachment 688093 [details] [diff] [review]:
-----------------------------------------------------------------
This should go through the OpenBrowserWindowFromDockMenu function instead. Add an options argument there.
Attachment #688093 -
Flags: review?(josh) → review-
Assignee | ||
Comment 6•12 years ago
|
||
Fair enough.
Attachment #688093 -
Attachment is obsolete: true
Attachment #688096 -
Flags: review?(josh)
Updated•12 years ago
|
Attachment #688096 -
Flags: review?(josh) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: uiwanted
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•