Closed Bug 817138 Opened 12 years ago Closed 12 years ago

Back/Forward buttons should be recreated in code.

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox19 fixed, firefox20 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 20
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- verified

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(2 files)

Patch (1/2): Normal mode + Personas
(deleted), patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Patch (2/2): Private Browsing
(deleted), patch
mfinkle
: review+
Details | Diff | Splinter Review
Just like other ShapedButtons, Back and Forward should be re-created in code, so that they can enjoy all the glory of personas and private browsing!
This re-creates the buttons in code. Additionally, 1 UX bug on "forward is not aligned" is solved. Also, MDPI resource for forward was mis-aligned. That's replaced.
Attachment #687262 - Flags: review?(mark.finkle)
Attached patch Patch (2/2): Private Browsing (deleted) — — Splinter Review
And this is for private browsing mode.
Attachment #687263 - Flags: review?(mark.finkle)
Attachment #687262 - Attachment description: Patch → Patch (1/2): Normal mode + Personas
Assignee: nobody → sriram
Attachment #687262 - Flags: review?(mark.finkle) → review+
Attachment #687263 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/2626cd90bf2e https://hg.mozilla.org/mozilla-central/rev/57a020c3628b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
This issue is fixed on the latest Nightly. Closing bug as verified fixed on: Firefox 20.0a1 (2012-12-06) Device: Galaxy Tab 2 7" OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox20: --- → verified
Comment on attachment 687262 [details] [diff] [review] Patch (1/2): Normal mode + Personas [Approval Request Comment] Bug caused by (feature/regressing bug #): -- User impact if declined: The back/forward will not sport a nice and awesome image from personas. Testing completed (on m-c, etc.): Landed in m-c on 12/06 Risk to taking this patch (and alternatives if risky): Very less. Ian didn't find any difference :) String or UUID changes made by this patch: None.
Attachment #687262 - Flags: approval-mozilla-aurora?
Is this a product requirement for FF19?
I believe yes. It was filed after aurora merge, so not sure if this was triaged. Without this, the back/forward button will always be blue, and won't have the personas. Eg: http://cl.ly/image/1N0d1Z3I1z1l/o <-- The back button is having personas (which this patch does), but not the forward button (this patch does that.. but the image was taken before those bits got added to the patch).
Comment on attachment 687262 [details] [diff] [review] Patch (1/2): Normal mode + Personas approving for aurora in that case.
Attachment #687262 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This doesn't apply cleanly enough to Aurora for me to comfortably uplift. Sorry.
Flags: needinfo?(sriram)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: