Closed Bug 81717 Opened 24 years ago Closed 23 years ago

backslash in data: url converted to forward slash

Categories

(Core :: DOM: Navigation, defect)

x86
Windows 98
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: adamlock)

References

()

Details

Attachments

(1 file)

Found after bug 75063 was fixed: If a data: url contains a backslash, it's converted to a forward slash as soon as I press enter in the location bar. IMO, URL-munging should be opt-in (http, https, file only) rather than opt-out (everything except javascript, data, finger, what else?).
yea, opt-in makes sense to me too. there could be arbitrary URL implementations that need the backslash to remain un-touched.
I've changed the fixup code so it's more restrictive. It only happens to http, https, ftp protocols. It will also happens if there is no specified protocol, e.g. for when someone types "www.mozilla.org\projects". Backslashes will be passed through unmolested for all other situations.
Can I have a review on the patch please?
Keywords: patch, review
Can someone please review the patch? It won't get checked in until it is.
r=rpotts. It would be nice to have a more extensible/flexible way to handle this... but we can deal with that later :-)
sr=mscott
Fix is checked into trunk
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA to me, I'll cover this in the data: URL functional test.
QA Contact: adamlock → benc
Blocks: 144766
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: