Closed Bug 817348 Opened 12 years ago Closed 12 years ago

TBPL puppet scripts should not use variables containing hyphens

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Having just updated to Vagrant v1.0.5, I get: { [default] Running Puppet with /tmp/vagrant-puppet/manifests/init.pp... stdin: is not a tty Could not parse for environment production: Syntax error at '-'; expected '}' at /tmp/vagrant-puppet/manifests/classes/tbpl-base.pp:38 on node lucid32.hsd1.ca.comcast.net. } Line 38 is: > $main-package-list = [ It would seem that Puppet has never officially supported having hyphens in variable names, but it is only as of newer versions that this would cause an error: http://docs.puppetlabs.com/guides/language_guide.html { Acceptable Characters in Names Variable names can include alphanumeric characters and underscores, and are case-sensitive. Hyphens are not allowed; although some Puppet versions permit them, this is now considered a bug. }
hyphens
Summary: TBPL puppet scripts should not use variables containing hypens → TBPL puppet scripts should not use variables containing hyphens
Attached patch Patch v1 (deleted) — Splinter Review
Attachment #687470 - Flags: review?(rhelmer)
Attachment #687470 - Flags: review?(rhelmer) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 817713
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: