Bug 486918 added new image resizers from SKIA. Since this was enabled resized images on my ppc32 machine show up with a blue tint. The convolver code extracts the RGBA bits from each 32 bit pixel but doesn't take the endian order into account.

Comment on attachment 687479 [details] [diff] [review] proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits Review of attachment 687479 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/convolver.cpp @@ +206,3 @@ > if (has_alpha) > + accum[3] += cur_filter * source_data_rows[filter_y][byte_offset + > + A_OFFSET_IDX]; Can you just leave these all on the same line? @@ +231,5 @@ > // > // We only need to do this when generating the final output row (here). > + int max_color_channel = NS_MAX(out_row[byte_offset + R_OFFSET_IDX], > + NS_MAX(out_row[byte_offset + G_OFFSET_IDX], out_row[byte_offset > + + B_OFFSET_IDX])); Same line here too

Pushed v3 in https://hg.mozilla.org/integration/mozilla-inbound/rev/69b924c155b0

I would strongly recommend that the change to SkPreConfig.h gets a patch file added to gfx/skia/patches, or that this change be upstreamed to google's skia repo (or both!). Otherwise this change is at risk of being overwritten when we next update skia.

submitted for review upstream https://codereview.appspot.com/6900063/

This patch will add a patch file in gfx/skia/patches to alter SkPreConfig.h the next time we import upstream sources

Sorry! I was confusing SkPreConfig.h with SkUserConfig.h, and incorrectly figured it didn't need to have a separate patch.

Apparently attachment #690255 [details] [diff] [review] never went through review in m-c nor commited, and neither upstream who didnt reply on codereview. Should it be unbitrotten and r?'ed ? Stumbled upon this while investigating why skia got broken on ppc again (see #849253)...