Closed
Bug 817472
Opened 12 years ago
Closed 12 years ago
Port browser_394759_privatebrowsing.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: andreshm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
Reporter | |
Updated•12 years ago
|
Blocks: pbngentest
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → andres
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #687983 -
Flags: review?(ehsan)
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 687983 [details] [diff] [review]
Patch v1
Review of attachment 687983 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, but one question. This should not pass with bug 816524 backed out, right? In that case, I'm not sure what the landing plan for this and bug 816524 should be, since bug 816524 also regressed a whole bunch of other tests. Can you please do a try push with the patch from bug 816524, this one and the MOZ_PER_WINDOW_PRIVATE_BROWSING thing and see what else in the "bc" test is failing?
Thanks!
Attachment #687983 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e38460747ac6
|
|
Reporter | |
Comment 4•12 years ago
|
||
Hmm, that's pretty good, it doesn't include any new failures. I'll push both patches momentarily.
|
|
Reporter | |
Comment 5•12 years ago
|
||
(Filed bug 817931 about the last failure on Linux.)
|
|
Reporter | |
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•