Closed
Bug 817553
Opened 12 years ago
Closed 12 years ago
Fade the highlighter when sidebar is hovered.
Categories
(DevTools :: Inspector, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: paul, Assigned: Optimizer)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
It used to work. Regression since toolbox.
|
Reporter | |
Updated•12 years ago
|
Component: Developer Tools → Developer Tools: Inspector
|
|
Reporter | |
Updated•12 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [has-patch]
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 692624 [details] [diff] [review]
Hide on sidebar hover
The title of this bug is misleading. We want to hide the highlighter only when the ruleview is hovered (because we don't want the highlighter to disturb the user while change the style of the node).
Attachment #692624 -
Flags: review?(paul) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
So not on Computed view and/or Box Model ?
|
|
Reporter | |
Comment 4•12 years ago
|
||
(In reply to Girish Sharma [:Optimizer] from comment #3)
> So not on Computed view and/or Box Model ?
right.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Hide highlighter only on ruleview hover
Attachment #692624 -
Attachment is obsolete: true
Attachment #692992 -
Flags: review?(paul)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Hide highlighter only on ruleview hover
Attachment #692992 -
Attachment is obsolete: true
Attachment #692992 -
Flags: review?(paul)
Attachment #692994 -
Flags: review?(paul)
|
|
Reporter | |
Comment 7•12 years ago
|
||
Comment on attachment 692994 [details] [diff] [review]
only ruleview
Can you try to get the same behavior but without putting the event logic in Sidebar.jsm? Basically, don't touch Sidebar.jsm and move the event listeners in Inspector.jsm? If it doesn't work, I'm ok to keep your current approach.
Attachment #692994 -
Flags: review?(paul) → review-
|
|
Assignee | |
Comment 8•12 years ago
|
||
This makes things a bit more generic, other consumers of sidebar can also use the event.
Otherwise, I could add a method to get reference to a specific tab panel in the sidebar, then use that to add eventListener to ruleview tab ..
|
|
Reporter | |
Comment 9•12 years ago
|
||
(In reply to Girish Sharma [:Optimizer] from comment #8)
> This makes things a bit more generic, other consumers of sidebar can also
> use the event.
This behavior is so unique that I really don't think we should be generic.
|
|
Assignee | |
Comment 10•12 years ago
|
||
Done.
Added getTab method to get reference to the tab, and then added the event listeners in inspector panel only.
Attachment #692994 -
Attachment is obsolete: true
Attachment #693036 -
Flags: review?(paul)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #693036 -
Flags: review?(paul) → review+
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: [has-patch] → [land-in-fx-team]
|
|
Reporter | |
Comment 11•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 12•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•