Closed
Bug 817579
Opened 12 years ago
Closed 12 years ago
Command buttons in toolbox do not have tooltip
Categories
(DevTools :: General, defect, P2)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tetsuharu, Assigned: tetsuharu)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
Tilt/responsive view/scratchpad command buttons in toolbox don't have tooltip.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → saneyuki.s.snyk
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #687802 -
Flags: review?(mihai.sucan)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 687802 [details] [diff] [review]
patch v1
Review of attachment 687802 [details] [diff] [review]:
-----------------------------------------------------------------
Paul: are you working on a patch for this issue?
Tetsuharu: thank you for your bug report and patch. This is something Paul should review.
This patch doesn't seem to work on my system (Ubuntu). I still don't see tooltips.
Attachment #687802 -
Flags: review?(mihai.sucan)
|
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Mihai Sucan [:msucan] from comment #2)
> This patch doesn't seem to work on my system (Ubuntu). I still don't see
> tooltips.
I tried this patch on OSX, tooltiptext attribute is set correctly.
But the timing showing tooltip is severe. It may have other bug's effect...
|
|
Assignee | |
Comment 4•12 years ago
|
||
> I tried this patch on OSX, tooltiptext attribute is set correctly.
> But the timing showing tooltip is severe. It may have other bug's effect...
Sorry. This is my mistake.
When I had tried the patch, it worked correctly. But when I have attached the patch v1 to bugzilla, I modified the patch unintentionally...
New patch v2 is working correctly. Please review it.
Attachment #687802 -
Attachment is obsolete: true
Attachment #688238 -
Flags: review?(mihai.sucan)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 688238 [details] [diff] [review]
patch v2
Review of attachment 688238 [details] [diff] [review]:
-----------------------------------------------------------------
r+ from me, but could we in DeveloperToolbar.jsm, do
if (command.tooltipText != null) {
button.setAttribute("tooltiptext", command.tooltipText);
}
else if (command.description != null) {
button.setAttribute("tooltiptext", command.description);
}
Attachment #688238 -
Flags: review?(mihai.sucan) → review+
|
|
||
Comment 6•12 years ago
|
||
Mihai, obviously don't let my r+ prevent you from reviewing if you want to.
|
|
Assignee | |
Comment 7•12 years ago
|
||
This followed Joe's comment.
I ask Mihai to review this again tentatively.
Attachment #688238 -
Attachment is obsolete: true
Attachment #688702 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 8•12 years ago
|
||
This followed Joe's comment.
I ask Mihai to review this again tentatively.
Attachment #688238 -
Attachment is obsolete: true
Attachment #688704 -
Flags: review?(mihai.sucan)
|
||
Comment 9•12 years ago
|
||
Comment on attachment 688702 [details] [diff] [review]
patch v3
(Double post of attachment)
Attachment #688702 -
Attachment is obsolete: true
Attachment #688702 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 10•12 years ago
|
||
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #9)
> Comment on attachment 688702 [details] [diff] [review]
> patch v3
>
> (Double post of attachment)
Thank you, Ed.
|
|
||
Comment 11•12 years ago
|
||
Comment on attachment 688704 [details] [diff] [review]
patch v3
This works for me now. Thank you Tetsuharu!
Also thanks Joe for looking into the patch. I wanted Paul or you to check this patch before I gave my r+.
Attachment #688704 -
Flags: review?(mihai.sucan) → review+
|
|
||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
|
|
||
Comment 12•12 years ago
|
||
Landed in fx-team:
https://hg.mozilla.org/integration/fx-team/rev/2939067fa4e3
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
|
Assignee | |
Comment 13•12 years ago
|
||
(In reply to Mihai Sucan [:msucan] from comment #12)
> Landed in fx-team:
>
> https://hg.mozilla.org/integration/fx-team/rev/2939067fa4e3
Thank you, Mihai!
|
||
Updated•12 years ago
|
Priority: -- → P2
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 15•12 years ago
|
||
(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #14)
> https://tbpl.mozilla.org/?rev=8a30e07815ff
Joe, what happen?
|
|
Assignee | |
Comment 16•12 years ago
|
||
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•