The file layout/html/forms/src/nsFormFrame.cpp contains a lot of calls to the function PL_strlen() which are unnecessary. If these calls would be to strlen() instead expressions like strlen("FOO") would be optimized by the compiler to the constant 3. But since PL_strlen is used this cannot happen. I'll attach a patch which replaces these uses of PL_strlen() with uses of sizeof. sizeof is already used in some places in this file so the concept is not new. There is one more little patch included: one sprintf() call included in the parameter list a string constant. Instead of doing this simply use the string concatenation feature of the compiler which is in the same sprintf() call already done with the macro CRLF.

This is all eric's code and he is doing some modifications to submits - reassigning

Looks good to me. I say drop it in if the patch hasn't bit-rotted.

Bulk reassigning form bugs to Alex

s/strlen/sizeof :)

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)

don't move bugs that are in the 1.0 dependency tree. sorry.

Reassigning to John. Moved to Moz1.1

This *will* be fixed in bug 120682. Lengths are calculated after everything is concatenated together rather than in a big ol' separate loop. I just did a search on "strlen" in the code and found nothing, in fact.

Marking nsbeta1+

Checked in.

verifying according to comment #9 ("I just did a search on "strlen" in the code and found nothing, in fact.")