Closed
Bug 817656
Opened 12 years ago
Closed 12 years ago
Speed up slow ratings tests
Categories
(Marketplace Graveyard :: Code Quality, defect, P4)
Tracking
(Not tracked)
RESOLVED
WONTFIX
2013-01-10
People
(Reporter: andy+bugzilla, Assigned: ashort)
References
Details
(Keywords: perf)
The slowest test in terms of setup time (fixtures, everything in setUp) is: zamboni.mkt.ratings.tests.test_views.TestCreate And of the 20 slowest tests, a couple of the tests in that class are the slowest, eg: zamboni.mkt.ratings.tests.test_views.TestCreate.test_body_has_url zamboni.mkt.ratings.tests.test_views.TestListing.test_detail_local_reviews_only etc.. clocking in at around 3.5 seconds a test.
Updated•12 years ago
|
Assignee: nobody → ashort
Priority: -- → P4
Target Milestone: --- → 2013-01-10
Assignee | ||
Comment 1•12 years ago
|
||
Got around a 30% speedup. Most of the time is spent in the ORM, of course. https://github.com/mozilla/zamboni/commit/ec681e2f867dcc6c88117c6199167779eea73968
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•12 years ago
|
||
It still shows up as the slowest test in the site however. http://cl.ly/image/1M3w152X3p3G
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•12 years ago
|
||
making our tests faster is going to require an overhaul of more than a few things.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → WONTFIX
Updated•10 years ago
|
Blocks: marketplace-perf
You need to log in
before you can comment on or make changes to this bug.
Description
•